Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/telemetry/telemetry/core/timeline/trace_event_importer.py

Issue 23936003: telemetry: Fixed bug in trace_event_importer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/timeline/trace_event_importer.py
diff --git a/tools/telemetry/telemetry/core/timeline/trace_event_importer.py b/tools/telemetry/telemetry/core/timeline/trace_event_importer.py
index aff6ec5a005be135b152bea9678197f59bf6d97e..aa5edabc9f91daa182b74bc933e9cd8ae8985a10 100644
--- a/tools/telemetry/telemetry/core/timeline/trace_event_importer.py
+++ b/tools/telemetry/telemetry/core/timeline/trace_event_importer.py
@@ -274,8 +274,8 @@ class TraceEventTimelineImporter(importer.TimelineImporter):
async_event_states_by_name_then_id[name] = {}
if event_id in async_event_states_by_name_then_id[name]:
self._model.import_errors.append(
- 'At ' + event['ts'] + ', a slice of the same id ' + event_id +
- ' was alrady open.')
+ 'At %d, a slice of the same id %s was alrady open.' % (
+ event['ts'], event_id))
continue
async_event_states_by_name_then_id[name][event_id] = []
@@ -284,13 +284,12 @@ class TraceEventTimelineImporter(importer.TimelineImporter):
else:
if name not in async_event_states_by_name_then_id:
self._model.import_errors.append(
- 'At ' + str(event['ts']) + ', no slice named ' + name +
- ' was open.')
+ 'At %d, no slice named %s was open.' % (event['ts'], name,))
continue
if event_id not in async_event_states_by_name_then_id[name]:
self._model.import_errors.append(
- 'At ' + str(event['ts']) + ', no slice named ' + name +
- ' with id=' + event_id + ' was open.')
+ 'At %d, no slice named %s with id=%s was open.' % (
+ event['ts'], name, event_id))
continue
events = async_event_states_by_name_then_id[name][event_id]
events.append(async_event_state)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698