Issue 23926003: Take time_offset into account when ticking animations that are Starting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23926003: Take time_offset into account when ticking animations that are Starting (Closed)

Created:
7 years, 3 months ago by ajuma

Modified:
7 years, 3 months ago

Reviewers:
Ian Vollick

CC:
chromium-reviews, cc-bugs_chromium.org, avallee

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Take time_offset into account when ticking animations that are Starting LayerAnimationController::TickAnimations ignores the time_offset for animations that are Starting and for animations waiting for a synchronized start time. This CL makes Animation::TrimTimeToCurrentIteration handle computing the trimmed time for such animations, removing the need for TickAnimations to have special cases for computing trimmed time. BUG=284590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221257

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -10 lines)			Patch
M	cc/animation/animation.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	cc/animation/animation_unittest.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	cc/animation/layer_animation_controller.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/23926003/1

7 years, 3 months ago (2013-09-04 18:46:32 UTC) #3

Message was sent while issue was closed.

Change committed as 221257

Expand Messages | Collapse Messages