Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23918002: Switch to doing user-resizing via system for panels on Mac (Closed)

Created:
7 years, 3 months ago by jianli
Modified:
7 years, 3 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Switch to doing user-resizing via system for panels on Mac We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems. Also removed EnableResizeByMouse which is not really used in our code. BUG=282652, 282657 TEST=manual test by user-resizing panels Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221651 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221765

Patch Set 1 : Patch #

Total comments: 1

Patch Set 2 : Patch #

Total comments: 1

Patch Set 3 : Patch to land #

Patch Set 4 : Patch to reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -297 lines) Patch
M chrome/browser/ui/cocoa/panels/panel_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_utils_cocoa.mm View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 1 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 9 chunks +165 lines, -261 lines 0 comments Download
M chrome/browser/ui/gtk/panels/panel_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/panels/panel_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/detached_panel_collection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_collection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/stacked_panel_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/stacked_panel_collection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
7 years, 3 months ago (2013-09-03 20:26:08 UTC) #1
Dmitry Titov
lgtm with 2 nits: https://codereview.chromium.org/23918002/diff/3001/chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h File chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h (right): https://codereview.chromium.org/23918002/diff/3001/chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h#newcode21 chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h:21: // corner) to the platfrom-independent ...
7 years, 3 months ago (2013-09-05 20:49:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/23918002/37001
7 years, 3 months ago (2013-09-05 21:42:47 UTC) #3
commit-bot: I haz the power
Change committed as 221651
7 years, 3 months ago (2013-09-06 08:40:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/23918002/58001
7 years, 3 months ago (2013-09-06 17:29:45 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 20:17:04 UTC) #6
Message was sent while issue was closed. 
Change committed as 221765

Powered by Google App Engine
This is Rietveld 408576698