Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390423002: Fix try-catch optimizer. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix try-catch optimizer. When identifying constants in the catch-environment, make sure that the environment refers to the same constant definition at all throwing instructions. BUG=#27483 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b5f92d2bfc81efecb90528d039b939827d4d9d3b

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M runtime/vm/redundancy_elimination.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/language/try_catch_regress_27483_test.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 2 months ago (2016-10-04 21:13:16 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2390423002/diff/1/tests/language/try_catch_regress_27483_test.dart File tests/language/try_catch_regress_27483_test.dart (right): https://chromiumcodereview.appspot.com/2390423002/diff/1/tests/language/try_catch_regress_27483_test.dart#newcode6 tests/language/try_catch_regress_27483_test.dart:6: // VMOptions=--optimization-counter-threshold=100 --no-background-compilation --enable-inling-annotations inlining
4 years, 2 months ago (2016-10-04 21:32:30 UTC) #3
Florian Schneider
https://chromiumcodereview.appspot.com/2390423002/diff/1/tests/language/try_catch_regress_27483_test.dart File tests/language/try_catch_regress_27483_test.dart (right): https://chromiumcodereview.appspot.com/2390423002/diff/1/tests/language/try_catch_regress_27483_test.dart#newcode6 tests/language/try_catch_regress_27483_test.dart:6: // VMOptions=--optimization-counter-threshold=100 --no-background-compilation --enable-inling-annotations On 2016/10/04 21:32:30, rmacnak wrote: ...
4 years, 2 months ago (2016-10-04 21:36:32 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-04 21:39:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b5f92d2bfc81efecb90528d039b939827d4d9d3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698