DevTools: hoist debugger paused reason to top

DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068
Committed: https://crrev.com/5fa5d3b7589a798770e0f5df18d14939cd16f8a9
Cr-Commit-Position: refs/heads/master@{#427553}

[luoe, 2016-10-08 02:25:20]

Description was changed from

==========
DevTools: hoist debugger paused reason to top

BUG=572068
==========

to

==========
DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068
==========

[luoe, 2016-10-08 02:25:30]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-10-08 02:25:31]

ptal

[lushnikov, 2016-10-12 21:26:59]

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:145:
createBreakpointHitSubMessage: function(details)
you don't need two functions - let's keep them as one

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:105:
this.element.appendChild(element);
this seems to be unrelated?

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:484: if
(details) {
if (details)
    status.appendChild(this._buildPausedMessage(pausedDetails));

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:487: if
(details.reason === WebInspector.DebuggerModel.BreakReason.DOM) {
Let's create a widget for this thing!

It will have one method: render(pausedDetails)

We'll be able to isolate a tone of css!

[luoe, 2016-10-13 00:36:58]

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:145:
createBreakpointHitSubMessage: function(details)
On 2016/10/12 21:26:58, lushnikov wrote:
> you don't need two functions - let's keep them as one

Done.

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:105:
this.element.appendChild(element);
On 2016/10/12 21:26:58, lushnikov wrote:
> this seems to be unrelated?

Done.

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:484: if
(details) {
On 2016/10/12 21:26:59, lushnikov wrote:
> if (details)
>     status.appendChild(this._buildPausedMessage(pausedDetails));

Done with a widget as this._debuggerPausedMessage.render(details);

https://codereview.chromium.org/2389883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:487: if
(details.reason === WebInspector.DebuggerModel.BreakReason.DOM) {
On 2016/10/12 21:26:59, lushnikov wrote:
> Let's create a widget for this thing!
> 
> It will have one method: render(pausedDetails)
> 
> We'll be able to isolate a tone of css!

Done as DebuggerPausedMessage.js

[dgozman, 2016-10-13 03:39:12]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-10-13 03:39:13]

https://codereview.chromium.org/2389883003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
(right):

https://codereview.chromium.org/2389883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:11:
WebInspector.VBox.call(this);
Please don't make something a widget if you just want to scope css. Use
WI.createShadowRootWithCoreStyles instead.

[luoe, 2016-10-14 00:04:38]

On 2016/10/13 03:39:13, dgozman wrote:
>
https://codereview.chromium.org/2389883003/diff/60001/third_party/WebKit/Sour...
> File
> third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
> (right):
> 
>
https://codereview.chromium.org/2389883003/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:11:
> WebInspector.VBox.call(this);
> Please don't make something a widget if you just want to scope css. Use
> WI.createShadowRootWithCoreStyles instead.

Right, there really isn't any Widget logic we need here.  Implemented as custom
element with shadow instead in patch 5.

[lushnikov, 2016-10-14 00:16:53]

I proposed using the custom element - but now it turns out to be somewhat
controversial. Dmirty, what do you think?

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
(right):

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:35:
render: function(details)
let's pass all the singletons we rely on here

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:45:
messageWrapper =
WebInspector.domBreakpointsSidebarPane.createBreakpointHitMessage(details);
let's use static method?

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:479: var
details = currentDebuggerModel && currentDebuggerModel.debuggerPausedDetails();
use "?"

[luoe, 2016-10-17 19:27:41]

In a chat with dgozman@, we considered making DebuggerPausedMessage.js similar
to Toolbar.js, a class that creates a shadow root, but isn't a custom element. 
We really don't need to inherit from HTMLDivPrototype for this.

Additional changes in the last patches
- Made enum for WI.DOMBreakpointsSidebarPane.BreakpointTypes,
BreakpointTypeLabels, BreakpointTypeNouns

Please take another look.

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
(right):

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:35:
render: function(details)
On 2016/10/14 00:16:53, lushnikov wrote:
> let's pass all the singletons we rely on here

Done.

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js:45:
messageWrapper =
WebInspector.domBreakpointsSidebarPane.createBreakpointHitMessage(details);
On 2016/10/14 00:16:53, lushnikov wrote:
> let's use static method?

Done.

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2389883003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:479: var
details = currentDebuggerModel && currentDebuggerModel.debuggerPausedDetails();
On 2016/10/14 00:16:53, lushnikov wrote:
> use "?"

Done.

[lushnikov, 2016-10-18 23:01:29]

lgtm

https://chromiumcodereview.appspot.com/2389883003/diff/120001/third_party/Web...
File
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css
(right):

https://chromiumcodereview.appspot.com/2389883003/diff/120001/third_party/Web...
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css:39:
font-size: 11px;
with .monospace, you won't need font-size as well!

https://chromiumcodereview.appspot.com/2389883003/diff/120001/third_party/Web...
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css:40:
font-family:  dejavu sans mono, monospace;
use .monospace for this!

[luoe, 2016-10-19 21:44:13]

Monospace added for the sub-text message.

https://codereview.chromium.org/2389883003/diff/120001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css
(right):

https://codereview.chromium.org/2389883003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css:39:
font-size: 11px;
On 2016/10/18 23:01:29, lushnikov wrote:
> with .monospace, you won't need font-size as well!

Done.

https://codereview.chromium.org/2389883003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/debuggerPausedMessage.css:40:
font-family:  dejavu sans mono, monospace;
On 2016/10/18 23:01:29, lushnikov wrote:
> use .monospace for this!

Done.

[luoe, 2016-10-19 21:44:21]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:22:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-10-20 00:39:51]

Test doesn't pass! :(
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html

[luoe, 2016-10-20 01:05:30]

On 2016/10/20 00:39:51, lushnikov wrote:
> Test doesn't pass! :(
>
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html

Strange...I just pulled, merged, and ran everything locally, and they all
passed.  Going to do another dry run.

[luoe, 2016-10-20 01:05:38]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 01:06:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 02:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:41:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-10-20 22:48:55]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:49:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 01:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:46:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-10-21 17:21:48]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:22:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 20:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 20:02:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-10-21 23:59:24]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 00:00:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-22 02:18:32]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-22 02:18:33]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-10-22 02:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2389883003/#ps160001
(title: "merge w/ master and fix async test")

[commit-bot: I haz the power, 2016-10-22 02:19:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 03:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 03:46:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-10-24 17:26:51]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 17:27:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:53:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-10-24 23:35:57]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:37:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 02:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 02:37:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-10-25 18:32:44]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:33:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-25 19:27:00]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 19:27:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 22:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:46:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-10-25 23:19:55]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:20:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-25 23:22:30]

Windows test was failing for multiple reasons:
- WI.UIString.capitalize() capitalizes strings on every platform except Windows,
intended to match the styles of native context menus
- Now that XHR Breakpoints show the url in the paused message, one of the XHR
tests was failing because Windows showed "file:///C:/foo" while other platforms
showed "file:///foo"

Patches 11 and 12 should fix these cases respectively.

[commit-bot: I haz the power, 2016-10-26 00:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:39:04]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-10-26 00:44:05]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-10-26 00:44:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2389883003/#ps220001
(title: "update test for windows compat")

[commit-bot: I haz the power, 2016-10-26 00:44:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 00:50:55]

Description was changed from

==========
DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068
==========

to

==========
DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068
==========

[commit-bot: I haz the power, 2016-10-26 00:50:57]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-10-26 00:53:00]

Description was changed from

==========
DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068
==========

to

==========
DevTools: hoist debugger paused reason to top

This interface change moves the paused reason (e.g. paused on breakpoint, paused
on subtree modification, etc) message to the top of the sources panel.  See bug
for screenshots.

BUG=572068

Committed: https://crrev.com/5fa5d3b7589a798770e0f5df18d14939cd16f8a9
Cr-Commit-Position: refs/heads/master@{#427553}
==========

[commit-bot: I haz the power, 2016-10-26 00:53:03]

Patchset 12 (id:??) landed as
https://crrev.com/5fa5d3b7589a798770e0f5df18d14939cd16f8a9
Cr-Commit-Position: refs/heads/master@{#427553}