Start Alt+Tab on MRU instead of MRU+1 if all windows are minimized.

ash/common/wm/window_cycle_list.cc

Index: ash/common/wm/window_cycle_list.cc
diff --git a/ash/common/wm/window_cycle_list.cc b/ash/common/wm/window_cycle_list.cc
index ed646a8e4f0bb8e8752c10718d7597edacd480fe..a1327e3e00faef5109ef45a78b76ca8a903eaba8 100644
--- a/ash/common/wm/window_cycle_list.cc
+++ b/ash/common/wm/window_cycle_list.cc
@@ -518,8 +518,14 @@ void WindowCycleList::Step(WindowCycleController::Direction direction) {
 
   DCHECK(static_cast<size_t>(current_index_) < windows_.size());
 
-  if (!cycle_view_ && current_index_ == 0)
+  if (!cycle_view_ && current_index_ == 0) {
     initial_direction_ = direction;
+    // Special case the situation where we're cycling forward but the MRU window
+    // is not active. This occurs when all windows are minimized. The starting
+    // window should be the first one rather than the second.
+    if (direction == WindowCycleController::FORWARD && !windows_[0]->IsActive())
+      current_index_ = -1;

[varkha, 2016/10/06 03:31:08]

Optional nit:
There logic is correct but still takes some effort to follow. For your
consideration - maybe just set a bool flag here instead of setting current_index
to an out of range value (-1) even though that is temporary. Then use that flag
below to skip the increment. I think this would be easier to read.

[Evan Stade, 2016/10/06 15:40:33]

I did write this in several different formats because I agree it's not the most
intuitive code ever. The brevity of this one won out. (I think tracing the value
of a bool that's conditionally set inside a conditional block has its own set of
readability issues.)

+  }
 
   // We're in a valid cycle, so step forward or backward.
   current_index_ += direction == WindowCycleController::FORWARD ? 1 : -1;