Start Alt+Tab on MRU instead of MRU+1 if all windows are minimized.

ash/common/wm/window_cycle_list.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/window_cycle_list.h"
 
 #include <list>
 #include <map>
 
 #include "ash/common/shell_window_ids.h"
@@ skipping 500 matching lines @@
   // window is minimized, we should also show it.
   if (windows_.size() == 1) {
     windows_[0]->Animate(::wm::WINDOW_ANIMATION_TYPE_BOUNCE);
     windows_[0]->Show();
     windows_[0]->GetWindowState()->Activate();
     return;
   }
 
   DCHECK(static_cast<size_t>(current_index_) < windows_.size());
 
-  if (!cycle_view_ && current_index_ == 0)
+  if (!cycle_view_ && current_index_ == 0) {
     initial_direction_ = direction;
+    // Special case the situation where we're cycling forward but the MRU window
+    // is not active. This occurs when all windows are minimized. The starting
+    // window should be the first one rather than the second.
+    if (direction == WindowCycleController::FORWARD && !windows_[0]->IsActive())
+      current_index_ = -1;

[varkha, 2016/10/06 03:31:08]

Optional nit:
There logic is correct but still takes some effort to follow. For your
consideration - maybe just set a bool flag here instead of setting current_index
to an out of range value (-1) even though that is temporary. Then use that flag
below to skip the increment. I think this would be easier to read.

[Evan Stade, 2016/10/06 15:40:33]

I did write this in several different formats because I agree it's not the most
intuitive code ever. The brevity of this one won out. (I think tracing the value
of a bool that's conditionally set inside a conditional block has its own set of
readability issues.)

+  }
 
   // We're in a valid cycle, so step forward or backward.
   current_index_ += direction == WindowCycleController::FORWARD ? 1 : -1;
 
   // Wrap to window list size.
   current_index_ = (current_index_ + windows_.size()) % windows_.size();
   DCHECK(windows_[current_index_]);
 
   if (ShouldShowUi()) {
     if (current_index_ > 1)
@@ skipping 87 matching lines @@
   widget->Init(params);
 
   screen_observer_.Add(display::Screen::GetScreen());
   widget->Show();
   widget->SetCapture(cycle_view_);
   widget->set_auto_release_capture(false);
   cycle_ui_widget_ = widget;
 }
 
 }  // namespace ash