Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 23890039: Do not rewrite AltGr Key as Alt+Ctrl (Closed)

Created:
7 years, 3 months ago by Seigo Nonaka
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, James Su, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not rewrite AltGr Key as Alt+Ctrl This is partial revert of http://crrev.com/215376 It turned out that this breaks browser accelerator triggered with Ctrl+Alt like spoken feedback or opening secure shell. And also that CL changes AltGr behavior to meet as Windows but some we application already works on current behaviors. As the result some application including Google Docs or Secure Shell breaks. So rewriting to Alt+Ctrl is no longer feasible conversion. BUG=253365, 288573, 287338 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224232

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove HTML file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -198 lines) Patch
D chrome/browser/chromeos/input_method/keyboard_browsertest.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/textinput/keyevent_logging.html View 1 1 chunk +0 lines, -70 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
Hi Jochen, This is partial revert of http://crrev.com/215376 to fix AltGr regressions on Chrome OS. ...
7 years, 3 months ago (2013-09-18 18:30:22 UTC) #1
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/23890039/diff/1/chrome/browser/chromeos/input_method/keyboard_browsertest.cc File chrome/browser/chromeos/input_method/keyboard_browsertest.cc (left): https://codereview.chromium.org/23890039/diff/1/chrome/browser/chromeos/input_method/keyboard_browsertest.cc#oldcode23 chrome/browser/chromeos/input_method/keyboard_browsertest.cc:23: base::FilePath(FILE_PATH_LITERAL("keyevent_logging.html"))); please also delete the html ...
7 years, 3 months ago (2013-09-19 12:34:31 UTC) #2
Seigo Nonaka
Thank you. Submitting... https://codereview.chromium.org/23890039/diff/1/chrome/browser/chromeos/input_method/keyboard_browsertest.cc File chrome/browser/chromeos/input_method/keyboard_browsertest.cc (left): https://codereview.chromium.org/23890039/diff/1/chrome/browser/chromeos/input_method/keyboard_browsertest.cc#oldcode23 chrome/browser/chromeos/input_method/keyboard_browsertest.cc:23: base::FilePath(FILE_PATH_LITERAL("keyevent_logging.html"))); On 2013/09/19 12:34:32, jochen wrote: ...
7 years, 3 months ago (2013-09-19 19:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/23890039/6001
7 years, 3 months ago (2013-09-19 19:07:02 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 23:34:32 UTC) #5
Message was sent while issue was closed.
Change committed as 224232

Powered by Google App Engine
This is Rietveld 408576698