Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5518)

Unified Diff: chrome/browser/chromeos/input_method/keyboard_browsertest.cc

Issue 23890039: Do not rewrite AltGr Key as Alt+Ctrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove HTML file Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/keyboard_browsertest.cc
diff --git a/chrome/browser/chromeos/input_method/keyboard_browsertest.cc b/chrome/browser/chromeos/input_method/keyboard_browsertest.cc
deleted file mode 100644
index fb3579dbe15758bf6c1d8c7775901bf3ab5cf1bf..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/input_method/keyboard_browsertest.cc
+++ /dev/null
@@ -1,96 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/chromeos/input_method/textinput_test_helper.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/test/base/interactive_test_utils.h"
-#include "content/public/test/browser_test_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace chromeos {
-
-typedef TextInputTestBase KeyboardEventEndToEndTest;
-
-// Flaky test: 268049
-IN_PROC_BROWSER_TEST_F(KeyboardEventEndToEndTest,
- DISABLED_AltGrToCtrlAltKeyDown) {
- TextInputTestHelper helper;
-
- GURL url = ui_test_utils::GetTestUrl(
- base::FilePath(FILE_PATH_LITERAL("textinput")),
- base::FilePath(FILE_PATH_LITERAL("keyevent_logging.html")));
- ui_test_utils::NavigateToURL(browser(), url);
-
- content::WebContents* tab =
- browser()->tab_strip_model()->GetActiveWebContents();
-
- helper.ClickElement("text_id", tab);
- helper.WaitForTextInputStateChanged(ui::TEXT_INPUT_TYPE_TEXT);
-
- {
- ASSERT_TRUE(content::ExecuteScript(
- tab,
- "initKeyDownExpectations(["
- // Alt down has (only) altKey true in this case.
- "{ keyCode:18, shiftKey:false, ctrlKey:false, altKey:true }]);"));
- EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(),
- ui::VKEY_MENU,
- false,
- false,
- false,
- false));
- bool result = false;
- ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
- tab,
- "didTestSucceed();",
- &result));
- EXPECT_TRUE(result);
- }
- {
- ASSERT_TRUE(content::ExecuteScript(
- tab,
- "initKeyDownExpectations(["
- // Ctrl down has (only) ctrlKey true in this case.
- "{ keyCode:17, shiftKey:false, ctrlKey:true, altKey:false }]);"));
- EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(),
- ui::VKEY_CONTROL,
- false,
- false,
- false,
- false));
- bool result = false;
- ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
- tab,
- "didTestSucceed();",
- &result));
- EXPECT_TRUE(result);
- }
- {
- ASSERT_TRUE(content::ExecuteScript(
- tab,
- "initKeyDownExpectations(["
- // Ctrl down has ctrlKey false in this case.
- "{ keyCode:17, shiftKey:false , ctrlKey:false , altKey:false },"
- // Alt down has altKey false in this case.
- "{ keyCode:18, shiftKey:false , ctrlKey:false , altKey:false }]);"));
- EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(),
- ui::VKEY_ALTGR,
- false,
- false,
- false,
- false));
- bool result = false;
- ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
- tab,
- "didTestSucceed();",
- &result));
- EXPECT_TRUE(result);
- }
-}
-
-// TODO(nona): Add AltGr modifier test. Need to add AltGr handling into
-// SendKeyPressSync(crbug.com/262928).
-
-} // namespace chromeos
« no previous file with comments | « no previous file | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698