Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 23885004: Do not perform unnecessary install for device status dashboard step. (Closed)

Created:
7 years, 3 months ago by navabi
Modified:
7 years, 3 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Do not perform unnecessary install for device status dashboard step. BUG=254014 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
navabi
7 years, 3 months ago (2013-09-05 20:31:32 UTC) #1
navabi
On 2013/09/05 20:31:32, navabi wrote: Ping.
7 years, 3 months ago (2013-09-09 19:15:26 UTC) #2
navabi
Ping. This is causing errors (though not step failure) for the device status check dashboard ...
7 years, 3 months ago (2013-09-17 00:53:47 UTC) #3
cmp
lgtm
7 years, 3 months ago (2013-09-17 00:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/23885004/1
7 years, 3 months ago (2013-09-17 01:04:14 UTC) #5
commit-bot: I haz the power
Change committed as 223555
7 years, 3 months ago (2013-09-17 06:57:09 UTC) #6
Isaac (away)
We're running device status twice ? Once for dashboard and once during run? This seems...
7 years, 3 months ago (2013-09-17 08:28:21 UTC) #7
navabi
7 years, 3 months ago (2013-09-17 15:54:07 UTC) #8
Message was sent while issue was closed.
On 2013/09/17 08:28:21, Isaac wrote:
> We're running device status twice ?  Once for dashboard and once during run? 
> This seems...

Yes. Because the new perf dashboard requires that the step be run as buidbot
step.

Powered by Google App Engine
This is Rietveld 408576698