Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2444)

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 23885004: Do not perform unnecessary install for device status dashboard step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_status_check.py
diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py
index 90c7cfbb70940be1d50322260fe9d5c8864d4c5e..5065ef77334a1398fb162287bbd54225e637e5d3 100755
--- a/build/android/buildbot/bb_device_status_check.py
+++ b/build/android/buildbot/bb_device_status_check.py
@@ -42,9 +42,6 @@ def DeviceInfo(serial, options):
device_product_name = device_adb.GetProductName()
battery = device_adb.GetBatteryInfo()
- install_output = GetCmdOutput(
- ['%s/build/android/adb_install_apk.py' % constants.DIR_SOURCE_ROOT, '--apk',
- '%s/build/android/CheckInstallApk-debug.apk' % constants.DIR_SOURCE_ROOT])
def _GetData(re_expression, line, lambda_function=lambda x:x):
if not line:
@@ -54,7 +51,17 @@ def DeviceInfo(serial, options):
return lambda_function(found[0])
return 'Unknown'
- install_speed = _GetData('(\d+) KB/s', install_output)
+ if options.device_status_dashboard:
+ # Dashboard does not track install speed. Do not unnecessarily install.
+ install_speed = 'Unknown'
+ else:
+ install_output = GetCmdOutput(
+ ['%s/build/android/adb_install_apk.py' % constants.DIR_SOURCE_ROOT,
+ '--apk',
+ '%s/build/android/CheckInstallApk-debug.apk' % constants.DIR_SOURCE_ROOT
+ ])
+ install_speed = _GetData('(\d+) KB/s', install_output)
+
ac_power = _GetData('AC powered: (\w+)', battery)
battery_level = _GetData('level: (\d+)', battery)
battery_temp = _GetData('temperature: (\d+)', battery,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698