media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo

media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo

Rather than use a TypeConvertor, reference the existing
IPC_STRUCT_TRAITS.

BUG=611750
TEST=media_mojo_unittests pass

Committed: https://crrev.com/a24563fb83909069d596263b44269611e2d6c439
Cr-Commit-Position: refs/heads/master@{#423066}

[jrummell, 2016-10-04 01:21:31]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-10-04 01:21:31]

PTAL

[xhwang, 2016-10-04 05:14:54]

Looking pretty good. I just have one question about deps.

https://chromiumcodereview.appspot.com/2388383002/diff/1/media/mojo/interface...
File media/mojo/interfaces/subsample_entry.typemap (right):

https://chromiumcodereview.appspot.com/2388383002/diff/1/media/mojo/interface...
media/mojo/interfaces/subsample_entry.typemap:9: "//media/gpu/ipc/common",
In theory, media/mojo doesn't depend on media/gpu, so this deps looks a bit odd.
Could you please move the IPC::Params from
//media/gpu/ipc/common/media_param_traits_macros.h to
//media/base/ipc/media_param_traits.h to work around this? Or maybe we can just
have StructTraits instead of using existing ParamTraits.

[jrummell, 2016-10-04 17:56:15]

Patchset #2 (id:20001) has been deleted

[jrummell, 2016-10-04 17:58:40]

Moved the IPC_STRUCT_TRAITS to base/ipc, switched to use a generic
media_types.typemap.

https://codereview.chromium.org/2388383002/diff/1/media/mojo/interfaces/subsa...
File media/mojo/interfaces/subsample_entry.typemap (right):

https://codereview.chromium.org/2388383002/diff/1/media/mojo/interfaces/subsa...
media/mojo/interfaces/subsample_entry.typemap:9: "//media/gpu/ipc/common",
On 2016/10/04 05:14:54, xhwang wrote:
> In theory, media/mojo doesn't depend on media/gpu, so this deps looks a bit
odd.
> Could you please move the IPC::Params from
> //media/gpu/ipc/common/media_param_traits_macros.h to
> //media/base/ipc/media_param_traits.h to work around this? Or maybe we can
just
> have StructTraits instead of using existing ParamTraits.

Done.

[xhwang, 2016-10-04 18:05:44]

lgtm

[jrummell, 2016-10-04 18:10:14]

jrummell@chromium.org changed reviewers:
+ dcheng@chromium.org

[jrummell, 2016-10-04 18:10:15]

+dcheng@ for security review.

[dcheng, 2016-10-04 18:22:49]

I'm a bit confused: it says "from the existing ipc struct traits", but there
isn't one, since we added a new one.

Any reason not to just implement the struct traits natively in mojo?

[jrummell, 2016-10-04 18:44:53]

On 2016/10/04 18:22:49, dcheng wrote:
> I'm a bit confused: it says "from the existing ipc struct traits", but there
> isn't one, since we added a new one.
> 
> Any reason not to just implement the struct traits natively in mojo?

I moved the IPC_STRUCT_TRAITS from
media/gpu/ipc/common/media_param_traits_macros.h to
media/base/ipc/media_param_traits_macros.h so that media/mojo doesn't have a
dependency on media/gpu.

[dcheng, 2016-10-04 19:16:40]

Oops, duh. Sorry for missing that. LGTM

[jrummell, 2016-10-04 19:49:33]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:50:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 19:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:59:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jrummell, 2016-10-04 23:17:06]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-10-04 23:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2388383002/#ps60001
(title: "fix build issues")

[commit-bot: I haz the power, 2016-10-04 23:17:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:41:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-05 03:45:46]

Description was changed from

==========
media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo

Rather than use a TypeConvertor, reference the existing
IPC_STRUCT_TRAITS.

BUG=611750
TEST=media_mojo_unittests pass
==========

to

==========
media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo

Rather than use a TypeConvertor, reference the existing
IPC_STRUCT_TRAITS.

BUG=611750
TEST=media_mojo_unittests pass

Committed: https://crrev.com/a24563fb83909069d596263b44269611e2d6c439
Cr-Commit-Position: refs/heads/master@{#423066}
==========

[commit-bot: I haz the power, 2016-10-05 03:45:48]

Patchset 3 (id:??) landed as
https://crrev.com/a24563fb83909069d596263b44269611e2d6c439
Cr-Commit-Position: refs/heads/master@{#423066}