media/mojo/interfaces/subsample_entry.typemap - Issue 2388383002: media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/mojo/interfaces/subsample_entry.typemap

Issue 2388383002: media: Use IPC_STRUCT_TRAITS to convert SubsampleEntry for mojo (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//media/mojo/interfaces/subsample_entry.mojom"

	6 public_headers = [ "//media/base/decrypt_config.h" ]

	7 traits_headers = [ "//media/gpu/ipc/common/media_param_traits_macros.h" ]

	8 deps = [

	9 "//media/gpu/ipc/common",
	xhwang 2016/10/04 05:14:54 In theory, media/mojo doesn't depend on media/gpu, In theory, media/mojo doesn't depend on media/gpu, so this deps looks a bit odd. Could you please move the IPC::Params from //media/gpu/ipc/common/media_param_traits_macros.h to //media/base/ipc/media_param_traits.h to work around this? Or maybe we can just have StructTraits instead of using existing ParamTraits. jrummell 2016/10/04 17:58:40 Done. Show quoted text On 2016/10/04 05:14:54, xhwang wrote: > In theory, media/mojo doesn't depend on media/gpu, so this deps looks a bit odd. > Could you please move the IPC::Params from > //media/gpu/ipc/common/media_param_traits_macros.h to > //media/base/ipc/media_param_traits.h to work around this? Or maybe we can just > have StructTraits instead of using existing ParamTraits. Done.
	10 ]

	11 type_mappings = [ "media.mojom.SubsampleEntry=media::SubsampleEntry" ]

OLD	NEW

« no previous file with comments | « media/mojo/interfaces/subsample_entry.mojom ('k') | media/mojo/interfaces/typemaps.gni » ('j') | no next file with comments »