Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 23874008: Added memory limit for chrome.activityLogPrivate returned results (Closed)

Created:
7 years, 3 months ago by felt
Modified:
7 years, 3 months ago
Reviewers:
Matt Perry
CC:
mvrable, karenlees, chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Added memory limit for chrome.activityLogPrivate returned results The Activity Log will only send a max of 300 rows per lookup. This should be completely satisfactory for the Watchdog app -- we can't display more than 300 rows of data in any meaninful way anyway. This is also below the IPC memory boundary. BUG=241672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M chrome/browser/extensions/activity_log/counting_policy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/activity_log_private.json View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
felt
Hi Matt, Can you please review this? By the way, thanks for telling me about ...
7 years, 3 months ago (2013-09-04 02:11:40 UTC) #1
Matt Perry
LGTM I was just guessing about the 1MB limit - I don't remember exactly what ...
7 years, 3 months ago (2013-09-04 19:34:25 UTC) #2
felt
On 2013/09/04 19:34:25, Matt Perry wrote: > LGTM > > I was just guessing about ...
7 years, 3 months ago (2013-09-04 19:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/23874008/1
7 years, 3 months ago (2013-09-04 23:19:57 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82812
7 years, 3 months ago (2013-09-05 00:31:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/23874008/1
7 years, 3 months ago (2013-09-05 00:44:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82880
7 years, 3 months ago (2013-09-05 01:41:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/23874008/1
7 years, 3 months ago (2013-09-05 12:36:21 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 13:26:58 UTC) #9
Message was sent while issue was closed.
Change committed as 221406

Powered by Google App Engine
This is Rietveld 408576698