chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc - Issue 23874008: Added memory limit for chrome.activityLogPrivate returned results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 23874008: Added memory limit for chrome.activityLogPrivate returned results (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc ('k') | chrome/common/extensions/api/activity_log_private.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

index dd8ba68bda96c8697bbc08706869c5e0f37c50bd..719889dea945bf476faae73b61599b9b22e5e6a5 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

@@ -163,12 +163,8 @@ void ActivityLogPrivateGetExtensionActivitiesFunction::OnLookupCompleted(

}

// Populate the return object.

- // TODO(felt): Implement paging. Right now max_time and more_results are

- // placeholder values.

scoped_ptr<ActivityResultSet> result_set(new ActivityResultSet);

result_set->activities = result_arr;

- result_set->max_time = scoped_ptr<int>(new int(0));

- result_set->more_results = false;

results_ = activity_log_private::GetExtensionActivities::Results::Create(

*result_set);