Add metadata for type parameters (TypeVariableMirror).

Add metadata to type parameters. Reflective access is provided by TypeVariableMirror.

Addresses issue 10906.

BUG=https://code.google.com/p/dart/issues/detail?id=10906
R=asiva@google.com, rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27523

[Michael Lippautz (Google), 2013-09-12 17:51:20]

As far as I see, this is the last metadata piece missing. Implementation is
similar to what is already there.

[rmacnak, 2013-09-13 01:13:28]

https://chromiumcodereview.appspot.com/23872010/diff/5001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23872010/diff/5001/runtime/vm/object.c...
runtime/vm/object.cc:6554: return String::Concat(cname, pname);
We can have a type parameter and function or field with the same name in the
same class.

mport 'dart:mirrors';

const m = 'm';
const n = 'n';

class G<@n T> {
  @m T() => 4;
}

main(){
  print(reflectClass(G).typeVariables[const Symbol('T')].metadata);
  print(reflectClass(G).methods[const Symbol('T')].metadata);
}

prints
n
n

[Michael Lippautz (Google), 2013-09-13 01:42:17]

Thanks!

I also added tests checking for metadata when name conflicts occur.

https://chromiumcodereview.appspot.com/23872010/diff/5001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23872010/diff/5001/runtime/vm/object.c...
runtime/vm/object.cc:6554: return String::Concat(cname, pname);
On 2013/09/13 01:13:28, Ryan Macnak wrote:
> We can have a type parameter and function or field with the same name in the
> same class.
> 
> mport 'dart:mirrors';
> 
> const m = 'm';
> const n = 'n';
> 
> class G<@n T> {
>   @m T() => 4;
> }
> 
> main(){
>   print(reflectClass(G).typeVariables[const Symbol('T')].metadata);
>   print(reflectClass(G).methods[const Symbol('T')].metadata);
> }
> 
> prints
> n
> n

I changed the separator symbol. We can change this back if it turns out that
overriding the name of a type parameter is not allowed.

[Michael Lippautz (Google), 2013-09-13 17:25:05]

PTAL

As name conflicts will become some sort of error again, I added TODOs to remove
the conflicting checks, once the the compiler/runtime is ready.

[siva, 2013-09-14 00:58:40]

lgtm

https://chromiumcodereview.appspot.com/23872010/diff/17001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23872010/diff/17001/runtime/vm/object....
runtime/vm/object.cc:6557: return String::Concat(cname, pname);
Why not create an array and invoke String::ConcatAll

String name = String::Handle();
Array parts = Array::Handle(Array::New(3));
name = MakeClassMetaName(.....);
array.SetAt(0,  name);
array.SetAt(1, Symbols::Slash());
name = param.name();
array.SetAt(2, name);
return String::ConcatAll(parts);

https://chromiumcodereview.appspot.com/23872010/diff/17001/tests/lib/mirrors/...
File tests/lib/mirrors/typevariable_mirror_metadata_test.dart (right):

https://chromiumcodereview.appspot.com/23872010/diff/17001/tests/lib/mirrors/...
tests/lib/mirrors/typevariable_mirror_metadata_test.dart:24: //
compiler/runtime.
Make an issue for these TODOs and use the issue number instead of an ldap
handle.

[Michael Lippautz (Google), 2013-09-16 16:44:35]

https://chromiumcodereview.appspot.com/23872010/diff/17001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/23872010/diff/17001/runtime/vm/object....
runtime/vm/object.cc:6557: return String::Concat(cname, pname);
On 2013/09/14 00:58:41, siva wrote:
> Why not create an array and invoke String::ConcatAll
> 
> String name = String::Handle();
> Array parts = Array::Handle(Array::New(3));
> name = MakeClassMetaName(.....);
> array.SetAt(0,  name);
> array.SetAt(1, Symbols::Slash());
> name = param.name();
> array.SetAt(2, name);
> return String::ConcatAll(parts);

Sure. Done.

https://chromiumcodereview.appspot.com/23872010/diff/17001/tests/lib/mirrors/...
File tests/lib/mirrors/typevariable_mirror_metadata_test.dart (right):

https://chromiumcodereview.appspot.com/23872010/diff/17001/tests/lib/mirrors/...
tests/lib/mirrors/typevariable_mirror_metadata_test.dart:24: //
compiler/runtime.
On 2013/09/14 00:58:41, siva wrote:
> Make an issue for these TODOs and use the issue number instead of an ldap
> handle.

Done.

[rmacnak, 2013-09-16 16:51:10]

lgtm

[Michael Lippautz (Google), 2013-09-16 16:53:31]

Committed patchset #6 manually as r27523 (presubmit successful).