Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issue 23868020: Fix remaining shared_library link_settings propagation (Closed)

Created:
7 years, 3 months ago by Shezan Baig (Bloomberg)
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, weitaosu+watch_chromium.org, piman+watch_chromium.org, alexeypa+watch_chromium.org, rmsousa+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix remaining shared_library link_settings propagation These changes are necessary to make Chromium build without taking advantage of a GYP bug that allowed propagation of link_settings out of a shared_library target. The GYP bug has been fixed in r1717. BUG=

Patch Set 1 #

Patch Set 2 : fix issues from patchset 1 #

Patch Set 3 : fix issues from patchset 2 #

Patch Set 4 : fix issues from patchset 3 #

Patch Set 5 : fix issues from patchset 4 #

Patch Set 6 : fix issues from patchset 5 #

Patch Set 7 : fix issues from patchset 6 #

Patch Set 8 : fix issues from patchset 7 #

Patch Set 9 : fix issues from patchset 8 #

Patch Set 10 : fix issues from patchset 9 #

Patch Set 11 : fix issues from patchset 10 #

Patch Set 12 : fix issues from patchset 11 #

Patch Set 13 : fix issues from patchset 12 #

Patch Set 14 : fix issues from patchset 13 #

Patch Set 15 : fix issues from patchset 14 #

Patch Set 16 : fix issues from patchset 15 #

Patch Set 17 : fix issues from patchset 16 #

Patch Set 18 : fix issues from patchset 17 #

Patch Set 19 : fix issues from patchset 18 #

Patch Set 20 : fix issues from patchset 19 #

Patch Set 21 : fix issues from patchset 20 #

Patch Set 22 : fix issues from patchset 21 #

Patch Set 23 : fix issues from patchset 22 #

Patch Set 24 : rebase #

Patch Set 25 : rebase #

Patch Set 26 : fix issues from patchset 25 #

Patch Set 27 : fix issues from patchset 26 #

Patch Set 28 : fix issues from patchset 27 #

Patch Set 29 : fix issues from patchset 28 #

Patch Set 30 : rebase #

Patch Set 31 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -0 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +7 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +9 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +7 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +5 lines, -0 lines 0 comments Download
M crypto/crypto.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/command_buffer.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/gpu_config.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +9 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +2 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +10 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +19 lines, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sync/sync_core.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M testing/android/native_test.gyp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +10 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M ui/shell_dialogs.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +9 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -0 lines 0 comments Download
M ui/surface/surface.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +10 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Shezan Baig (Bloomberg)
Mark, this is the list of changes to chromium in order to build with the ...
7 years, 2 months ago (2013-10-11 15:22:45 UTC) #1
Shezan Baig (Bloomberg)
Please let me know if I should split this into smaller patches for each sub-directory ...
7 years, 2 months ago (2013-10-11 16:16:58 UTC) #2
Shezan Baig (Bloomberg)
7 years, 1 month ago (2013-11-14 00:16:13 UTC) #3
This is a pretty huge patch :(
I'll close this issue and publish separate patches for each subdir.
Stay tuned! :)

Powered by Google App Engine
This is Rietveld 408576698