chrome/chrome.gyp - Issue 23868020: Fix remaining shared_library link_settings propagation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 23868020: Fix remaining shared_library link_settings propagation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index 95642f742851571d213666f10f1e68ec517a4f4b..5a27d7055884eafb5fa4e4cb4509eef4ee16408a 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -530,6 +530,7 @@

'link_settings': {

'libraries': [

+ '$(SDKROOT)/System/Library/Frameworks/AppKit.framework',

'$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',

'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',

@@ -697,6 +698,12 @@

'sources': [

'tools/mac_helpers/infoplist_strings_util.mm',

+ 'link_settings': {

+ 'libraries': [

+ '$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',

+ '$(SDKROOT)/System/Library/Frameworks/Foundation.framework',

+ ],

+ },

], # targets

}], # OS=="mac"

« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »