Use the top-level URL for popup blocking.

Use the top-level URL for popup blocking.

BUG=289004
R=cdn@chromium.org,bauerb@chromium.org
TEST=manually, as described in the bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222640

[jochen (gone - plz use gerrit), 2013-09-11 15:40:49]

plz review

Cris, IPC changes
Bernhard, everything
Jonathan, android_webview rubberstamp

[joth, 2013-09-11 15:45:49]

On Wednesday, 11 September 2013,  <jochen@chromium.org> wrote:
> plz review
>
> Cris, IPC changes
> Bernhard, everything
> Jonathan, android_webview rubberstamp
>
>
Lgtm

https://codereview.chromium.org/23868017/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bernhard Bauer, 2013-09-11 16:37:46]

https://codereview.chromium.org/23868017/diff/1/chrome/browser/chrome_content...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/23868017/diff/1/chrome/browser/chrome_content...
chrome/browser/chrome_content_browser_client.cc:2026:
opener_top_level_frame_url,
Should we pass the |opener_url| as one of the parameters here?

[jochen (gone - plz use gerrit), 2013-09-11 16:45:25]

https://codereview.chromium.org/23868017/diff/1/chrome/browser/chrome_content...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/23868017/diff/1/chrome/browser/chrome_content...
chrome/browser/chrome_content_browser_client.cc:2026:
opener_top_level_frame_url,
On 2013/09/11 16:37:46, Bernhard Bauer wrote:
> Should we pass the |opener_url| as one of the parameters here?
We can consider that in a future cl. For now, I want to restore the original
behavior.

[Bernhard Bauer, 2013-09-11 17:07:35]

OK, LGTM

[Cris Neckar, 2013-09-11 17:32:10]

IPC changes LGTM

[commit-bot: I haz the power, 2013-09-11 17:33:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/23868017/1

[commit-bot: I haz the power, 2013-09-11 17:47:45]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jochen (gone - plz use gerrit), 2013-09-11 18:00:06]

John, can you please review the content/public bits (and cq+ if you like it)

[jam, 2013-09-11 18:23:18]

lgtm

[commit-bot: I haz the power, 2013-09-11 18:23:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/23868017/1

[commit-bot: I haz the power, 2013-09-11 21:43:00]

Change committed as 222640