Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4306)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 23868017: Use the top-level URL for popup blocking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index bcc19670fbbb302b04432cd99c00cdc717a7d867..14d9731e907741efe5259c250446ddee7bfe9fdc 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1955,6 +1955,7 @@ void ChromeContentBrowserClient::CancelDesktopNotification(
bool ChromeContentBrowserClient::CanCreateWindow(
const GURL& opener_url,
+ const GURL& opener_top_level_frame_url,
const GURL& source_origin,
WindowContainerType container_type,
const GURL& target_url,
@@ -2021,8 +2022,8 @@ bool ChromeContentBrowserClient::CanCreateWindow(
if (!user_gesture && !CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisablePopupBlocking)) {
- if (content_settings->GetContentSetting(opener_url,
- opener_url,
+ if (content_settings->GetContentSetting(opener_top_level_frame_url,
+ opener_top_level_frame_url,
Bernhard Bauer 2013/09/11 16:37:46 Should we pass the |opener_url| as one of the para
jochen (gone - plz use gerrit) 2013/09/11 16:45:25 We can consider that in a future cl. For now, I wa
CONTENT_SETTINGS_TYPE_POPUPS,
std::string()) ==
CONTENT_SETTING_ALLOW) {
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698