Issue 23851011: Remove unavailable shortcut silently instead of showing a confirmation dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23851011: Remove unavailable shortcut silently instead of showing a confirmation dialog (Closed)

Created:
7 years, 3 months ago by yoshiki

Modified:
7 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unavailable shortcut silently instead of showing a confirmation dialog This patch is a reland of r219741, which had been reverted since it was conflicted with the another patch. BUG=287597 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222041

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -39 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/directory_model.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/navigation_list.js	View	10 chunks	+67 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yoshiki

@hirono, could you take a look? This patch is almost same as http://crbug.com/23420003/. I've just ...

7 years, 3 months ago (2013-09-09 05:08:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23851011/1

7 years, 3 months ago (2013-09-09 05:39:54 UTC) #3

Message was sent while issue was closed.

Change committed as 222041

Expand Messages | Collapse Messages