Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/resources/file_manager/js/directory_model.js

Issue 23851011: Remove unavailable shortcut silently instead of showing a confirmation dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/directory_model.js
diff --git a/chrome/browser/resources/file_manager/js/directory_model.js b/chrome/browser/resources/file_manager/js/directory_model.js
index 6cdf6986480514d87a86498104b8b702859324b8..0d21e1f605100e76496ae67602c1a940cd1a9dfd 100644
--- a/chrome/browser/resources/file_manager/js/directory_model.js
+++ b/chrome/browser/resources/file_manager/js/directory_model.js
@@ -886,8 +886,8 @@ DirectoryModel.prototype.createDirectory = function(name, successCallback,
* Changes directory. Causes 'directory-change' event.
*
* @param {string} path New current directory path.
- * @param {function()=} opt_errorCallback Executed if the change directory
- * failed.
+ * @param {function(FileError)=} opt_errorCallback Executed if the change
+ * directory failed.
*/
DirectoryModel.prototype.changeDirectory = function(path, opt_errorCallback) {
if (PathUtil.isSpecialSearchRoot(path)) {
@@ -900,7 +900,7 @@ DirectoryModel.prototype.changeDirectory = function(path, opt_errorCallback) {
}.bind(this), function(error) {
console.error('Error changing directory to ' + path + ': ', error);
if (opt_errorCallback)
- opt_errorCallback();
+ opt_errorCallback(error);
});
};

Powered by Google App Engine
This is Rietveld 408576698