Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 23819030: Move WifiDataProvider implementation out of header. (Closed)

Created:
7 years, 3 months ago by Michael van Ouwerkerk
Modified:
7 years, 3 months ago
Reviewers:
bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move WifiDataProvider implementation out of header. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -43 lines) Patch
M content/browser/geolocation/wifi_data_provider.h View 3 chunks +10 lines, -43 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider.cc View 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael van Ouwerkerk
Hi Marcus, this is some minor cleanup as followup to our earlier discussions.
7 years, 3 months ago (2013-09-06 15:27:56 UTC) #1
bulach
lgtm, thanks!
7 years, 3 months ago (2013-09-06 16:02:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/23819030/1
7 years, 3 months ago (2013-09-09 12:39:24 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 18:38:36 UTC) #4
Message was sent while issue was closed.
Change committed as 222062

Powered by Google App Engine
This is Rietveld 408576698