Move WifiDataProvider implementation out of header.

content/browser/geolocation/wifi_data_provider.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A wifi data provider provides wifi data from the device that is used by a
 // NetworkLocationProvider to obtain a position fix. We use a singleton
 // instance of the wifi data provider, which is used by multiple
 // NetworkLocationProvider objects.
 //
 // This file provides WifiDataProvider, which provides static methods to
@@ skipping 90 matching lines @@
 // We use a singleton instance of this class which is shared by multiple network
 // location providers. These location providers access the instance through the
 // Register and Unregister methods.
 class CONTENT_EXPORT WifiDataProvider {
  public:
   // Sets the factory function which will be used by Register to create the
   // implementation used by the singleton instance. This factory approach is
   // used both to abstract accross platform-specific implementations and to
   // inject mock implementations for testing.
   typedef WifiDataProviderImplBase* (*ImplFactoryFunction)(void);
-  static void SetFactory(ImplFactoryFunction factory_function_in) {
-    factory_function_ = factory_function_in;
-  }
+  static void SetFactory(ImplFactoryFunction factory_function_in);
 
-  static void ResetFactory() {
-    factory_function_ = DefaultFactoryFunction;
-  }
+  // Resets the factory function to the default.
+  static void ResetFactory();
 
   typedef base::Callback<void(WifiDataProvider*)> WifiDataUpdateCallback;
 
   // Registers a callback, which will be run whenever new data is available.
   // Instantiates the singleton if necessary, and always returns it.
   static WifiDataProvider* Register(WifiDataUpdateCallback* callback);
 
   // Removes a callback. If this is the last callback, deletes the singleton
   // instance. Return value indicates success.
-  static bool Unregister(WifiDataUpdateCallback* callback) {
-    DCHECK(instance_);
-    DCHECK(instance_->has_callbacks());
-    if (!instance_->RemoveCallback(callback)) {
-      return false;
-    }
-    if (!instance_->has_callbacks()) {
-      // Must stop the data provider (and any implementation threads) before
-      // destroying to avoid any race conditions in access to the provider in
-      // the destructor chain.
-      instance_->StopDataProvider();
-      delete instance_;
-      instance_ = NULL;
-    }
-    return true;
-  }
+  static bool Unregister(WifiDataUpdateCallback* callback);
 
   // Provides whatever data the provider has, which may be nothing. Return
   // value indicates whether this is all the data the provider could ever
   // obtain.
-  bool GetData(WifiData* data) {
-    return impl_->GetData(data);
-  }
+  bool GetData(WifiData* data);
 
  private:
   // Private constructor and destructor, callers access singleton through
   // Register and Unregister.
   WifiDataProvider();
   virtual ~WifiDataProvider();
 
-  void AddCallback(WifiDataUpdateCallback* callback) {
-    impl_->AddCallback(callback);
-  }
+  void AddCallback(WifiDataUpdateCallback* callback);
+  bool RemoveCallback(WifiDataUpdateCallback* callback);
+  bool has_callbacks() const;
 
-  bool RemoveCallback(WifiDataUpdateCallback* callback) {
-    return impl_->RemoveCallback(callback);
-  }
-
-  bool has_callbacks() const {
-    return impl_->has_callbacks();
-  }
-
-  void StartDataProvider() {
-    impl_->StartDataProvider();
-  }
-
-  void StopDataProvider() {
-    impl_->StopDataProvider();
-  }
+  void StartDataProvider();
+  void StopDataProvider();
 
   static WifiDataProviderImplBase* DefaultFactoryFunction();
 
   // The singleton-like instance of this class. (Not 'true' singleton, as it
   // may go through multiple create/destroy/create cycles per process instance,
   // e.g. when under test).
   static WifiDataProvider* instance_;
 
   // The factory function used to create the singleton instance.
   static ImplFactoryFunction factory_function_;
 
   // The internal implementation.
   scoped_refptr<WifiDataProviderImplBase> impl_;
 
   DISALLOW_COPY_AND_ASSIGN(WifiDataProvider);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_GEOLOCATION_WIFI_DATA_PROVIDER_H_