Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 23819002: Files.app: Make the onDirectoryAction method private. (Closed)

Created:
7 years, 3 months ago by hirono
Modified:
7 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Make the onDirectoryAction method private. This method is used just internally. BUG=none TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hirono
Could you take a look this CL? Thanks!
7 years, 3 months ago (2013-08-30 09:35:50 UTC) #1
yoshiki
lgtm
7 years, 3 months ago (2013-08-30 09:39:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23819002/1
7 years, 3 months ago (2013-08-30 09:42:28 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 12:48:36 UTC) #4
Message was sent while issue was closed.
Change committed as 220568

Powered by Google App Engine
This is Rietveld 408576698