Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 23819002: Files.app: Make the onDirectoryAction method private. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index bab9f52f63461b1926f4842ff5da24d03234bd5a..94165d33bdfba5190c4143078a479d5e1a0e8a43 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -2304,7 +2304,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var entry = selection.entries[0];
if (entry.isDirectory) {
- this.onDirectoryAction(entry);
+ this.onDirectoryAction_(entry);
} else {
this.dispatchSelectionAction_();
}
@@ -2411,8 +2411,9 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
*
* @param {DirectoryEntry} entry Directory entry to which directory should be
* changed.
+ * @private
*/
- FileManager.prototype.onDirectoryAction = function(entry) {
+ FileManager.prototype.onDirectoryAction_ = function(entry) {
return this.directoryModel_.changeDirectory(entry.fullPath);
};
@@ -3089,7 +3090,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
this.dialogType != DialogType.SELECT_FOLDER &&
this.dialogType != DialogType.SELECT_UPLOAD_FOLDER) {
event.preventDefault();
- this.onDirectoryAction(selection.entries[0]);
+ this.onDirectoryAction_(selection.entries[0]);
} else if (this.dispatchSelectionAction_()) {
event.preventDefault();
}
@@ -3770,7 +3771,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
var entry = selectedItem.entry;
// If the entry is a directory, just change the directory.
if (entry.isDirectory) {
- this.onDirectoryAction(entry);
+ this.onDirectoryAction_(entry);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698