chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm ('k') | chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index 13493e44d4e864672801ec45ce1b3562f1bedde3..8f906ea7b62e3e1f34ddb01ddb04b7d5ff555ae0 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -210,7 +210,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

web_modal::WebContentsModalDialogManager::FromWebContents(

host_->host_contents());

if (modalDialogManager &&

- modalDialogManager->IsShowingDialog()) {

+ modalDialogManager->IsDialogActive()) {

return;

}

@@ -236,7 +236,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {