Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23814006: Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3. (Closed)

Created:
7 years, 3 months ago by dshwang
Modified:
7 years, 3 months ago
Reviewers:
jam, Chris Evans
CC:
chromium-reviews, tfarina, jam, robertshield, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fd
Visibility:
Public.

Description

Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221809

Patch Set 1 #

Patch Set 2 : CL for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/test/automation/proxy_launcher.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ipc/ipc_test_base.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dshwang
7 years, 3 months ago (2013-09-06 11:46:30 UTC) #1
jam
lgtm
7 years, 3 months ago (2013-09-06 16:24:58 UTC) #2
dshwang
On 2013/09/06 16:24:58, jam wrote: > lgtm thank you :)
7 years, 3 months ago (2013-09-06 17:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/23814006/1
7 years, 3 months ago (2013-09-06 17:21:26 UTC) #4
dshwang
On 2013/09/06 17:21:11, dshwang wrote: > On 2013/09/06 16:24:58, jam wrote: > > lgtm > ...
7 years, 3 months ago (2013-09-06 17:22:11 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-06 17:43:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/23814006/31001
7 years, 3 months ago (2013-09-06 19:31:58 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 23:11:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 221809

Powered by Google App Engine
This is Rietveld 408576698