Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: ipc/ipc_test_base.cc

Issue 23814006: Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fd
Patch Set: CL for landing Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/firefox_importer_unittest_utils_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_test_base.cc
diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc
index 5e16e42cd8d1db0ae332d85bfa4df63a81d6645a..ef050a7151f2a24b9cdfbd45424e0c6850ce6268 100644
--- a/ipc/ipc_test_base.cc
+++ b/ipc/ipc_test_base.cc
@@ -14,6 +14,10 @@
#include "ipc/ipc_descriptors.h"
#include "ipc/ipc_switches.h"
+#if defined(OS_POSIX)
+#include "base/posix/global_descriptors.h"
+#endif
+
// static
std::string IPCTestBase::GetChannelName(const std::string& test_client_name) {
DCHECK(!test_client_name.empty());
@@ -102,7 +106,8 @@ bool IPCTestBase::StartClient() {
const int ipcfd = channel_.get() ? channel_->GetClientFileDescriptor() :
channel_proxy_->GetClientFileDescriptor();
if (ipcfd > -1)
- fds_to_map.push_back(std::pair<int, int>(ipcfd, kPrimaryIPCChannel + 3));
+ fds_to_map.push_back(std::pair<int, int>(ipcfd,
+ kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor));
client_process_ = MultiProcessTest::SpawnChild(test_main,
fds_to_map,
« no previous file with comments | « chrome/utility/importer/firefox_importer_unittest_utils_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698