Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2379783002: Instant App Banner logic. (Closed)
Patch Set: Alphabetize and rename constants Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 2d75eed74428ec31a55b5ba55ac10f448326a0fd..03587cb6bdb9e00845a49354ec40a55e20f053df 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -431,6 +431,23 @@ bool AppBannerManager::CheckIfShouldShowBanner() {
if (code == NO_ERROR_DETECTED)
return true;
+ switch (code) {
+ case ALREADY_INSTALLED:
+ banners::TrackDisplayEvent(banners::DISPLAY_EVENT_INSTALLED_PREVIOUSLY);
+ break;
+ case PREVIOUSLY_BLOCKED:
+ banners::TrackDisplayEvent(banners::DISPLAY_EVENT_BLOCKED_PREVIOUSLY);
+ break;
+ case PREVIOUSLY_IGNORED:
+ banners::TrackDisplayEvent(banners::DISPLAY_EVENT_IGNORED_PREVIOUSLY);
+ break;
+ case INSUFFICIENT_ENGAGEMENT:
+ banners::TrackDisplayEvent(banners::DISPLAY_EVENT_NOT_VISITED_ENOUGH);
+ break;
+ default:
+ break;
+ }
+
// If we are in debug mode, AppBannerSettingsHelper::ShouldShowBanner must
// return NO_ERROR_DETECTED (bypass flag is set) or we must not have entered
// this method.

Powered by Google App Engine
This is Rietveld 408576698