Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/android/instantapps/instant_apps_settings.cc

Issue 2379783002: Instant App Banner logic. (Closed)
Patch Set: Alphabetize and rename constants Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/instantapps/instant_apps_settings.cc
diff --git a/chrome/browser/android/instantapps/instant_apps_settings.cc b/chrome/browser/android/instantapps/instant_apps_settings.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2ff400f46791cce3652d0049c783c56fbb3f1d33
--- /dev/null
+++ b/chrome/browser/android/instantapps/instant_apps_settings.cc
@@ -0,0 +1,103 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/instantapps/instant_apps_settings.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
+#include "base/time/time.h"
+#include "base/values.h"
+#include "chrome/browser/banners/app_banner_settings_helper.h"
+#include "chrome/browser/installable/installable_logging.h"
+#include "content/public/browser/web_contents.h"
+#include "jni/InstantAppsSettings_jni.h"
+#include "url/gurl.h"
+
+using base::android::JavaParamRef;
+using base::android::ConvertJavaStringToUTF8;
+
+const char InstantAppsSettings::kInstantAppsKey[] = "instantapps";
+
+void InstantAppsSettings::RecordInfoBarShowEvent(
+ content::WebContents* web_contents,
+ const std::string& url) {
+ AppBannerSettingsHelper::RecordBannerEvent(
+ web_contents,
+ GURL(url),
+ kInstantAppsKey,
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_SHOW,
+ base::Time::Now());
+}
+
+void InstantAppsSettings::RecordInfoBarDismissEvent(
+ content::WebContents* web_contents,
+ const std::string& url) {
+ AppBannerSettingsHelper::RecordBannerEvent(
+ web_contents,
+ GURL(url),
+ kInstantAppsKey,
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
+ base::Time::Now());
+}
+
+static void SetInstantAppDefault(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents,
+ const JavaParamRef<jstring>& jurl) {
+ content::WebContents* web_contents =
+ content::WebContents::FromJavaWebContents(jweb_contents);
+ DCHECK(web_contents);
+
+ std::string url(ConvertJavaStringToUTF8(env, jurl));
+
+ AppBannerSettingsHelper::RecordBannerEvent(
+ web_contents,
+ GURL(url),
+ InstantAppsSettings::kInstantAppsKey,
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
Ted C 2016/09/30 18:01:34 should we have a TODO to change the enum name to A
Maria 2016/09/30 20:35:18 Done.
+ base::Time::Now());
+}
+
+static jboolean GetInstantAppDefault(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents,
+ const JavaParamRef<jstring>& jurl) {
+ content::WebContents* web_contents =
+ content::WebContents::FromJavaWebContents(jweb_contents);
+ DCHECK(web_contents);
+
+ std::string url(ConvertJavaStringToUTF8(env, jurl));
+
+ // Don't show if it has been added to the homescreen.
Ted C 2016/09/30 18:01:34 comment doesn't seem applicable (or needs further
Maria 2016/09/30 20:35:18 Yeah, I probably copied it
+ base::Time added_time = AppBannerSettingsHelper::GetSingleBannerEvent(
+ web_contents,
+ GURL(url),
+ InstantAppsSettings::kInstantAppsKey,
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN);
+
+ return !added_time.is_null();
+}
+
+static jboolean ShouldShowBanner(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents,
+ const JavaParamRef<jstring>& jurl) {
+ content::WebContents* web_contents =
+ content::WebContents::FromJavaWebContents(jweb_contents);
+ DCHECK(web_contents);
+
+ std::string url(ConvertJavaStringToUTF8(env, jurl));
+
+ return AppBannerSettingsHelper::ShouldShowBanner(
+ web_contents,
+ GURL(url),
+ InstantAppsSettings::kInstantAppsKey,
+ base::Time::Now()) == InstallableStatusCode::NO_ERROR_DETECTED;
+}
+
+bool RegisterInstantAppsSettings(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}

Powered by Google App Engine
This is Rietveld 408576698