Issue 23792002: Set the WindowId of the SessionTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23792002: Set the WindowId of the SessionTabHelper (Closed)

Created:
7 years, 3 months ago by David Trainor- moved to gerrit

Modified:
7 years, 3 months ago

Reviewers:
Ted C, nyquist

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the WindowId of the SessionTabHelper - When initializing the WebContents for Android pull the WindowId from the TabModel and push it to the SessionTabHelper. BUG=277135 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221798

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Address Comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
		chrome/browser/android/tab_android.cc	View	1 2 3	2 chunks	+13 lines, -0 lines	0 comments	Download
		chrome/browser/ui/android/tab_model/tab_model_list.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nyquist

lgtm https://chromiumcodereview.appspot.com/23792002/diff/1/chrome/browser/android/tab_android.cc File chrome/browser/android/tab_android.cc (right): https://chromiumcodereview.appspot.com/23792002/diff/1/chrome/browser/android/tab_android.cc#newcode190 chrome/browser/android/tab_android.cc:190: // Set the window ID if we have ...

7 years, 3 months ago (2013-08-30 01:06:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/23792002/13001

7 years, 3 months ago (2013-09-06 22:30:03 UTC) #4

Message was sent while issue was closed.

Change committed as 221798

Expand Messages | Collapse Messages