Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/browser/android/tab_android.cc

Issue 23792002: Set the WindowId of the SessionTabHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/android/tab_model/tab_model_list.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/tab_android.h" 5 #include "chrome/browser/android/tab_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "chrome/browser/android/chrome_web_contents_delegate_android.h" 8 #include "chrome/browser/android/chrome_web_contents_delegate_android.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 10 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
11 #include "chrome/browser/extensions/tab_helper.h" 11 #include "chrome/browser/extensions/tab_helper.h"
12 #include "chrome/browser/favicon/favicon_tab_helper.h" 12 #include "chrome/browser/favicon/favicon_tab_helper.h"
13 #include "chrome/browser/history/history_tab_helper.h" 13 #include "chrome/browser/history/history_tab_helper.h"
14 #include "chrome/browser/infobars/infobar_service.h" 14 #include "chrome/browser/infobars/infobar_service.h"
15 #include "chrome/browser/password_manager/password_manager.h" 15 #include "chrome/browser/password_manager/password_manager.h"
16 #include "chrome/browser/password_manager/password_manager_delegate_impl.h" 16 #include "chrome/browser/password_manager/password_manager_delegate_impl.h"
17 #include "chrome/browser/prerender/prerender_tab_helper.h" 17 #include "chrome/browser/prerender/prerender_tab_helper.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/profiles/profile_android.h" 19 #include "chrome/browser/profiles/profile_android.h"
20 #include "chrome/browser/sessions/session_tab_helper.h" 20 #include "chrome/browser/sessions/session_tab_helper.h"
21 #include "chrome/browser/ssl/ssl_tab_helper.h" 21 #include "chrome/browser/ssl/ssl_tab_helper.h"
22 #include "chrome/browser/translate/translate_tab_helper.h" 22 #include "chrome/browser/translate/translate_tab_helper.h"
23 #include "chrome/browser/ui/alternate_error_tab_observer.h" 23 #include "chrome/browser/ui/alternate_error_tab_observer.h"
24 #include "chrome/browser/ui/android/tab_model/tab_model.h"
25 #include "chrome/browser/ui/android/tab_model/tab_model_list.h"
24 #include "chrome/browser/ui/android/window_android_helper.h" 26 #include "chrome/browser/ui/android/window_android_helper.h"
25 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h" 27 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h"
26 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h" 28 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h"
27 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h" 29 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
28 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 30 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
29 #include "chrome/browser/ui/browser_tab_contents.h" 31 #include "chrome/browser/ui/browser_tab_contents.h"
30 #include "chrome/browser/ui/find_bar/find_tab_helper.h" 32 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
31 #include "chrome/browser/ui/prefs/prefs_tab_helper.h" 33 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
32 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 34 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
33 #include "chrome/browser/ui/toolbar/toolbar_model_impl.h" 35 #include "chrome/browser/ui/toolbar/toolbar_model_impl.h"
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 SessionTabHelper::FromWebContents(web_contents())->session_id().id()); 180 SessionTabHelper::FromWebContents(web_contents())->session_id().id());
179 WindowAndroidHelper::FromWebContents(web_contents())-> 181 WindowAndroidHelper::FromWebContents(web_contents())->
180 SetWindowAndroid(content_view_core->GetWindowAndroid()); 182 SetWindowAndroid(content_view_core->GetWindowAndroid());
181 CoreTabHelper::FromWebContents(web_contents())->set_delegate(this); 183 CoreTabHelper::FromWebContents(web_contents())->set_delegate(this);
182 web_contents_delegate_.reset( 184 web_contents_delegate_.reset(
183 new chrome::android::ChromeWebContentsDelegateAndroid( 185 new chrome::android::ChromeWebContentsDelegateAndroid(
184 env, jweb_contents_delegate)); 186 env, jweb_contents_delegate));
185 web_contents_delegate_->LoadProgressChanged(web_contents(), 0); 187 web_contents_delegate_->LoadProgressChanged(web_contents(), 0);
186 web_contents()->SetDelegate(web_contents_delegate_.get()); 188 web_contents()->SetDelegate(web_contents_delegate_.get());
187 189
190 // Set the window ID if we have a valid TabModel.
nyquist 2013/08/30 01:06:21 Nit: Try to avoid using pronouns.
191 TabModel* model = TabModelList::GetTabModelWithProfile(GetProfile());
192 if (model) {
193 SessionID window_id;
194 window_id.set_id(model->GetSessionId());
195
196 SessionTabHelper* session_tab_helper =
197 SessionTabHelper::FromWebContents(web_contents());
198 session_tab_helper->SetWindowID(window_id);
199 }
200
188 // Verify that the WebContents this tab represents matches the expected 201 // Verify that the WebContents this tab represents matches the expected
189 // off the record state. 202 // off the record state.
190 CHECK_EQ(GetProfile()->IsOffTheRecord(), incognito); 203 CHECK_EQ(GetProfile()->IsOffTheRecord(), incognito);
191 } 204 }
192 205
193 void TabAndroid::DestroyWebContents(JNIEnv* env, 206 void TabAndroid::DestroyWebContents(JNIEnv* env,
194 jobject obj, 207 jobject obj,
195 jboolean delete_native) { 208 jboolean delete_native) {
196 web_contents()->SetDelegate(NULL); 209 web_contents()->SetDelegate(NULL);
197 210
(...skipping 14 matching lines...) Expand all
212 ProfileAndroid* profile_android = ProfileAndroid::FromProfile(profile); 225 ProfileAndroid* profile_android = ProfileAndroid::FromProfile(profile);
213 if (!profile_android) 226 if (!profile_android)
214 return base::android::ScopedJavaLocalRef<jobject>(); 227 return base::android::ScopedJavaLocalRef<jobject>();
215 228
216 return profile_android->GetJavaObject(); 229 return profile_android->GetJavaObject();
217 } 230 }
218 231
219 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) { 232 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
220 return RegisterNativesImpl(env); 233 return RegisterNativesImpl(env);
221 } 234 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/android/tab_model/tab_model_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698