chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc - Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert startup_browser_creator_browsertest changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

index b7ab2f010d1eae9dbc7464ffc001e09305cec528..d60e74ef76f4ae9437119b4bb5408d4d530a838f 100644

--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

@@ -5,6 +5,7 @@

#include "base/command_line.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/devtools/devtools_window.h"

+#include "chrome/browser/search/search.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/singleton_tabs.h"

@@ -96,7 +97,7 @@ class ChromeRenderProcessHostTest : public InProcessBrowserTest {

EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());

tab1 = browser()->tab_strip_model()->GetWebContentsAt(tab_count - 1);

rph1 = tab1->GetRenderProcessHost();

- EXPECT_EQ(tab1->GetURL(), newtab);

+ EXPECT_TRUE(chrome::IsNTPURL(tab1->GetURL(), browser()->profile()));

EXPECT_EQ(host_count, RenderProcessHostCount());

// Create a new TYPE_TABBED tab. It should be in its own process.