chrome/browser/policy/policy_browsertest.cc - Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert startup_browser_creator_browsertest changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index 68fbe1903106dfd016b304ed210f99eee049ce1e..d9649a54131d9914a82d0ce3fa5839cbd09e693b 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -1619,7 +1619,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, HomepageLocation) {

UpdateProviderPolicy(policies);

EXPECT_TRUE(chrome::ExecuteCommand(browser(), IDC_HOME));

content::WaitForLoadStop(contents);

- EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), contents->GetURL());

+ EXPECT_TRUE(chrome::IsNTPURL(contents->GetURL(),browser()->profile()));

}

IN_PROC_BROWSER_TEST_F(PolicyTest, IncognitoEnabled) {