Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed)

Created:
7 years, 3 months ago by kmadhusu
Modified:
7 years, 3 months ago
Reviewers:
samarth, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, marja+watch_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

(Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). BUG=229009 TEST=none TBR=sky@chromium.org (chrome/browser changes OWNER check), samarth@chromium.org Original CL: crrev.com/22403003 Reverted CL: crrev.com/23475011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221594

Patch Set 1 : Patch from 22403003 #

Patch Set 2 : Revert startup_browser_creator_browsertest changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M chrome/browser/extensions/lazy_background_page_apitest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/23789005/6001
7 years, 3 months ago (2013-09-05 20:49:48 UTC) #1
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:02:09 UTC) #2
Message was sent while issue was closed.
Change committed as 221594

Powered by Google App Engine
This is Rietveld 408576698