Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2378773002: [Android] Remove //tools/android/forwarder. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove //tools/android/forwarder. BUG=413843 Committed: https://crrev.com/cb0834a4cebf46dc925dddd6e2f4ef836ab25b9c Cr-Commit-Position: refs/heads/master@{#421740}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -444 lines) Patch
D tools/android/forwarder/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/android/forwarder/forwarder.cc View 1 chunk +0 lines, -428 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbudorick
layout tests were the last user.
4 years, 2 months ago (2016-09-28 16:51:52 UTC) #2
Dirk Pranke
I think you need to update //BUILD.gn to remove the reference, as well. lgtm otherwise.
4 years, 2 months ago (2016-09-28 17:01:29 UTC) #3
jbudorick
On 2016/09/28 17:01:29, Dirk Pranke wrote: > I think you need to update //BUILD.gn to ...
4 years, 2 months ago (2016-09-28 17:03:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378773002/20001
4 years, 2 months ago (2016-09-28 23:50:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/38691)
4 years, 2 months ago (2016-09-29 01:29:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378773002/20001
4 years, 2 months ago (2016-09-29 03:12:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 03:46:16 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 03:50:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb0834a4cebf46dc925dddd6e2f4ef836ab25b9c
Cr-Commit-Position: refs/heads/master@{#421740}

Powered by Google App Engine
This is Rietveld 408576698