Issue 23785006: Telemetry: small fix for extra browser args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23785006: Telemetry: small fix for extra browser args. (Closed)

Created:
7 years, 3 months ago by bulach

Modified:
7 years, 3 months ago

Reviewers:
achuithb, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry: small fix for extra browser args. Following crrev.com/221590, use the new API instead. BUG=269131 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222030

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/core/browser_options.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/telemetry/telemetry/core/browser_options_unittest.py	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23785006/4001

7 years, 3 months ago (2013-09-09 09:53:14 UTC) #3

achuithb

On 2013/09/09 09:02:41, bulach wrote: > ptal Thanks for the fix and the test! lgtm

7 years, 3 months ago (2013-09-09 10:17:29 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=194976

7 years, 3 months ago (2013-09-09 13:07:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23785006/4001

7 years, 3 months ago (2013-09-09 13:11:24 UTC) #6

Message was sent while issue was closed.

Change committed as 222030

Expand Messages | Collapse Messages