tools/telemetry/telemetry/core/browser_options.py - Issue 23785006: Telemetry: small fix for extra browser args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 23785006: Telemetry: small fix for extra browser args. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index 8fcb2e5761c615def016b4c893d455f6c67eacee..aca8da6b847d6f1f2e30266bda1499679ea6defa 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -256,7 +256,7 @@ class BrowserOptions():

if hasattr(self, 'extra_browser_args_as_string'): # pylint: disable=E1101

tmp = shlex.split(

self.extra_browser_args_as_string) # pylint: disable=E1101

- self._extra_browser_args.extend(tmp)

+ self.AppendExtraBrowserArgs(tmp)

delattr(self, 'extra_browser_args_as_string')

if hasattr(self, 'extra_wpr_args_as_string'): # pylint: disable=E1101

tmp = shlex.split(

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/browser_options_unittest.py » ('j') | no next file with comments »