Create ExtensionsRendererClient.

Create ExtensionsRendererClient.

ExtensionsRendererClient defines an interface for clients
who wish to embed the extensions system into their renderer
processes.

This initial CL introduces two simple client methods to abstract
away Chrome dependencies within UserScriptSlave.

BUG=359836
R=yoz@chromium.org
TBR=jochen@chromium.org for ChromeContentRendererClient

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264097

[Ken Rockot(use gerrit already), 2014-04-14 21:29:33]

Yoyo can you please look at extensions changes?
James can you please look at apps/shell?

[Yoyo Zhou, 2014-04-14 21:39:05]

LGTM.
By the way, I don't believe we need UserScriptSlave for toro, but it is an
extensions concept rather than chrome, so this change makes sense in that sense.

https://chromiumcodereview.appspot.com/237833002/diff/1/apps/shell/renderer/s...
File apps/shell/renderer/shell_extensions_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/237833002/diff/1/apps/shell/renderer/s...
apps/shell/renderer/shell_extensions_renderer_client.cc:16: return 1;
What does this value mean? Document that we're not doing anything with it.

https://chromiumcodereview.appspot.com/237833002/diff/1/extensions/renderer/e...
File extensions/renderer/extensions_renderer_client.h (right):

https://chromiumcodereview.appspot.com/237833002/diff/1/extensions/renderer/e...
extensions/renderer/extensions_renderer_client.h:23: // Returns the lowest
isolated world ID available to extensions.
There should be a "See ..." pointer here.

[Ken Rockot(use gerrit already), 2014-04-14 22:05:28]

On 2014/04/14 21:39:05, Yoyo Zhou wrote:
> LGTM.
> By the way, I don't believe we need UserScriptSlave for toro, but it is an
> extensions concept rather than chrome, so this change makes sense in that
sense.
> 
>
https://chromiumcodereview.appspot.com/237833002/diff/1/apps/shell/renderer/s...
> File apps/shell/renderer/shell_extensions_renderer_client.cc (right):
> 
>
https://chromiumcodereview.appspot.com/237833002/diff/1/apps/shell/renderer/s...
> apps/shell/renderer/shell_extensions_renderer_client.cc:16: return 1;
> What does this value mean? Document that we're not doing anything with it.
> 
>
https://chromiumcodereview.appspot.com/237833002/diff/1/extensions/renderer/e...
> File extensions/renderer/extensions_renderer_client.h (right):
> 
>
https://chromiumcodereview.appspot.com/237833002/diff/1/extensions/renderer/e...
> extensions/renderer/extensions_renderer_client.h:23: // Returns the lowest
> isolated world ID available to extensions.
> There should be a "See ..." pointer here.

You're right, we don't need it. I might dig for some better candidate methods to
seed the renderer client then. While I agree it would be good to move this in
general, it would be unfortunate if the renderer side got moved but the browser
side (i.e. UserScriptMaster) got left behind because we don't have an immediate
need for it.

[James Cook, 2014-04-14 22:15:49]

LGTM with documentation nit

https://codereview.chromium.org/237833002/diff/1/apps/shell/renderer/shell_ex...
File apps/shell/renderer/shell_extensions_renderer_client.cc (right):

https://codereview.chromium.org/237833002/diff/1/apps/shell/renderer/shell_ex...
apps/shell/renderer/shell_extensions_renderer_client.cc:13: bool
ShellExtensionsRendererClient::IsIncognitoProcess() const { return false; }
nit: Specifically comment that app_shell does not support off-the-record
browsing.

https://codereview.chromium.org/237833002/diff/1/apps/shell/renderer/shell_ex...
apps/shell/renderer/shell_extensions_renderer_client.cc:16: return 1;
On 2014/04/14 21:39:05, Yoyo Zhou wrote:
> What does this value mean? Document that we're not doing anything with it.

ditto

[Ken Rockot(use gerrit already), 2014-04-14 23:05:14]

Thanks, doc nits addressed

[Ken Rockot(use gerrit already), 2014-04-14 23:06:45]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-04-14 23:07:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/237833002/20001

[commit-bot: I haz the power, 2014-04-15 06:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 06:30:34]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Ken Rockot(use gerrit already), 2014-04-15 16:36:46]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-04-15 16:38:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/237833002/20001

[commit-bot: I haz the power, 2014-04-15 19:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 19:41:13]

Failed to apply patch for extensions/extensions.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/extensions.gyp
  Hunk #1 FAILED at 415.
  1 out of 1 hunk FAILED -- saving rejects to file extensions/extensions.gyp.rej

Patch:       extensions/extensions.gyp
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index
cd8a01afd418db9d6f23065185eb7decdecd25b2..05fc126dd0173a033224fada44aff7c1c22d1f10
100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -415,6 +415,8 @@
       'sources': [
         'renderer/console.cc',
         'renderer/console.h',
+        'renderer/extensions_renderer_client.cc',
+        'renderer/extensions_renderer_client.h',
         'renderer/module_system.cc',
         'renderer/module_system.h',
         'renderer/native_handler.cc',

[Ken Rockot(use gerrit already), 2014-04-15 19:51:23]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-04-15 19:52:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/237833002/40001

[commit-bot: I haz the power, 2014-04-16 01:23:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/237833002/40001

[commit-bot: I haz the power, 2014-04-16 03:39:36]

Change committed as 264097