apps/shell/renderer/shell_extensions_renderer_client.cc - Issue 237833002: Create ExtensionsRendererClient.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/shell/renderer/shell_extensions_renderer_client.cc

Issue 237833002: Create ExtensionsRendererClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "apps/shell/renderer/shell_extensions_renderer_client.h"

	6

	7 namespace apps {

	8

	9 ShellExtensionsRendererClient::ShellExtensionsRendererClient() {}

	10

	11 ShellExtensionsRendererClient::~ShellExtensionsRendererClient() {}

	12

	13 bool ShellExtensionsRendererClient::IsIncognitoProcess() const { return false; }
	James Cook 2014/04/14 22:15:50 nit: Specifically comment that app_shell does not nit: Specifically comment that app_shell does not support off-the-record browsing.
	14

	15 int ShellExtensionsRendererClient::GetLowestIsolatedWorldId() const {

	16 return 1;
	Yoyo Zhou 2014/04/14 21:39:05 What does this value mean? Document that we're not What does this value mean? Document that we're not doing anything with it. James Cook 2014/04/14 22:15:50 ditto Show quoted text On 2014/04/14 21:39:05, Yoyo Zhou wrote: > What does this value mean? Document that we're not doing anything with it. ditto
	17 }

	18

	19 } // namespace apps

OLD	NEW