Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2378143002:
[sync]sync_integration_tests using python server fail (Closed)
|
Created:
4 years, 2 months ago by Patrick Noland Modified:
4 years, 2 months ago CC:
chromium-reviews, sync-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[sync]sync_integration_tests using python server fail
R=maxbogue@chromium.org,skym@chromium.org
BUG=649829
Committed: https://crrev.com/47e8a31625b0dee35912756abfcdbc1c9a751e8c
Cr-Commit-Position: refs/heads/master@{#421902}
Patch Set 1 : [sync]sync_integration_tests using python server fail #
Total comments: 2
Patch Set 2 : Added link to bug, fixed typo #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by pnoland@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by pnoland@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [sync]sync_integration_tests using python server fail R=skym@chromium.org BUG=649829 ========== to ========== [sync]sync_integration_tests using python server fail R=maxbogue@chromium.org,skym@chromium.org BUG=649829 ==========
pnoland@chromium.org changed reviewers: + maxbogue@chromium.org
max & sky, PTAL. This seemed easier than creating script that uses virtualenv, and doesn't seem to break anything on the trybots. Related reading: https://docs.python.org/2/using/cmdline.html#cmdoption-s
lgtm https://codereview.chromium.org/2378143002/diff/20001/components/sync/test/lo... File components/sync/test/local_sync_test_server.cc (right): https://codereview.chromium.org/2378143002/diff/20001/components/sync/test/lo... components/sync/test/local_sync_test_server.cc:41: // between pre-installed versions of python libraries, e.g. pyrproto. Can you add a link to the bug in this comment instead of just referencing pyrproto (also spelling?)
lgtm w/ nit and Sky's comment. https://codereview.chromium.org/2378143002/diff/20001/components/sync/test/lo... File components/sync/test/local_sync_test_server.cc (right): https://codereview.chromium.org/2378143002/diff/20001/components/sync/test/lo... components/sync/test/local_sync_test_server.cc:40: // Supress loading of site packages in order to avoid a version mismatch Suppress
The CQ bit was checked by pnoland@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maxbogue@chromium.org, skym@chromium.org Link to the patchset: https://codereview.chromium.org/2378143002/#ps40001 (title: "Added link to bug, fixed typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [sync]sync_integration_tests using python server fail R=maxbogue@chromium.org,skym@chromium.org BUG=649829 ========== to ========== [sync]sync_integration_tests using python server fail R=maxbogue@chromium.org,skym@chromium.org BUG=649829 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [sync]sync_integration_tests using python server fail R=maxbogue@chromium.org,skym@chromium.org BUG=649829 ========== to ========== [sync]sync_integration_tests using python server fail R=maxbogue@chromium.org,skym@chromium.org BUG=649829 Committed: https://crrev.com/47e8a31625b0dee35912756abfcdbc1c9a751e8c Cr-Commit-Position: refs/heads/master@{#421902} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/47e8a31625b0dee35912756abfcdbc1c9a751e8c Cr-Commit-Position: refs/heads/master@{#421902} |
