Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 23767005: Add getGLMatrix method to MatrixState (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 3 months ago
Reviewers:
Mark Kilgard, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add getGLMatrix method to MatrixState Removes redundant code by consolidating it into a single method. No change in functionality, this is strictly a refactoring. Committed: http://code.google.com/p/skia/source/detail?r=11112

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -64 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +5 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 2 chunks +44 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +6 lines, -37 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Chris Dalton
7 years, 3 months ago (2013-09-05 05:31:35 UTC) #1
bsalomon
On 2013/09/05 05:31:35, cdalton wrote: lgtm
7 years, 3 months ago (2013-09-05 13:00:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23767005/4001
7 years, 3 months ago (2013-09-05 13:01:03 UTC) #3
commit-bot: I haz the power
Change committed as 11112
7 years, 3 months ago (2013-09-05 18:28:47 UTC) #4
Mark Kilgard
looks good https://codereview.chromium.org/23767005/diff/4001/src/gpu/gl/GrGpuGL_program.cpp File src/gpu/gl/GrGpuGL_program.cpp (right): https://codereview.chromium.org/23767005/diff/4001/src/gpu/gl/GrGpuGL_program.cpp#newcode223 src/gpu/gl/GrGpuGL_program.cpp:223: GL_CALL(LoadMatrixf(projectionMatrix)); BTW, good opportunity to simply use ...
7 years, 3 months ago (2013-09-05 18:39:34 UTC) #5
bsalomon
7 years, 3 months ago (2013-09-05 18:40:44 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/23767005/diff/4001/src/gpu/gl/GrGpuGL_program...
File src/gpu/gl/GrGpuGL_program.cpp (right):

https://codereview.chromium.org/23767005/diff/4001/src/gpu/gl/GrGpuGL_program...
src/gpu/gl/GrGpuGL_program.cpp:223: GL_CALL(LoadMatrixf(projectionMatrix));
On 2013/09/05 18:39:34, markkilgard wrote:
> BTW, good opportunity to simply use DSA GL_CALL version of:
> 
> glMatrixLoadfEXT(GL_PROJECTION, projectionMatrix);
> 
> We are considering having a glMatrixLoad3x3fEXT entry point that would make
> sense here.

nice!

Powered by Google App Engine
This is Rietveld 408576698