Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2374883002: views/mus: Change 'reset(new' to base::MakeUnqiue. (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Change 'reset(new' to base::MakeUnqiue. Also ran git cl lint on these files. BUG=none Committed: https://crrev.com/d669540691d343abdd9cbe17de73871e6aabf46c Cr-Commit-Position: refs/heads/master@{#421548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M ui/views/mus/clipboard_mus.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/mus/input_method_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/input_method_mus_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/mus/pointer_watcher_event_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Elliot Glaysher
4 years, 2 months ago (2016-09-28 00:10:35 UTC) #6
sky
LGTM
4 years, 2 months ago (2016-09-28 15:39:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374883002/1
4 years, 2 months ago (2016-09-28 17:02:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 17:08:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 17:11:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d669540691d343abdd9cbe17de73871e6aabf46c
Cr-Commit-Position: refs/heads/master@{#421548}

Powered by Google App Engine
This is Rietveld 408576698