Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 23740010: Revert 223162 "Update the nine patch layer to use UI resources" (Closed)

Created:
7 years, 3 months ago by Zhenyao Mo
Modified:
7 years, 3 months ago
Reviewers:
powei
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223162 "Update the nine patch layer to use UI resources" Breaks GpuMemoryTest.SingleWindowDoesNotExceedLimit on gpu bots. One example: http://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Debug%20%28Intel%29/builds/11092/steps/content_browsertests/logs/SingleWindowDoesNotExceedLimit > Update the nine patch layer to use UI resources > > The old nine-patch layer used priority resource manager for requesting textures. > This patch updates the nine-patch layer to use the UI resource manager. > this patch clarifies the semantics of the aperture in both image and layer > The new semantics corresponds to existing logic on the android-side. > > Changes have been made to UIResourceBitmap to use SkPixelRef as ref-counted > of the bitmap content. > > The android-side changes: > https://gerrit-int.chromium.org/#/c/43103/ > > BUG=276482, 276487, 290215 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222732 > > Review URL: https://chromiumcodereview.appspot.com/22870016 TBR=powei@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -1086 lines) Patch
M trunk/src/cc/layers/nine_patch_layer.h View 1 chunk +15 lines, -28 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer.cc View 2 chunks +69 lines, -101 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_impl.h View 4 chunks +4 lines, -38 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_impl.cc View 14 chunks +110 lines, -184 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_impl_unittest.cc View 6 chunks +79 lines, -118 lines 0 comments Download
M trunk/src/cc/layers/nine_patch_layer_unittest.cc View 3 chunks +60 lines, -39 lines 0 comments Download
M trunk/src/cc/layers/painted_scrollbar_layer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/cc/layers/painted_scrollbar_layer.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M trunk/src/cc/layers/scrollbar_layer_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/cc/resources/scoped_ui_resource.h View 1 chunk +13 lines, -12 lines 0 comments Download
M trunk/src/cc/resources/scoped_ui_resource.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M trunk/src/cc/resources/ui_resource_bitmap.h View 2 chunks +18 lines, -22 lines 0 comments Download
M trunk/src/cc/resources/ui_resource_bitmap.cc View 1 chunk +12 lines, -32 lines 0 comments Download
M trunk/src/cc/resources/ui_resource_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/cc/test/data/10_10_layer_tree.json View 56 chunks +102 lines, -262 lines 0 comments Download
M trunk/src/cc/test/fake_scoped_ui_resource.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/cc/test/fake_scoped_ui_resource.cc View 1 chunk +10 lines, -19 lines 0 comments Download
M trunk/src/cc/test/layer_tree_json_parser.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.h View 3 chunks +6 lines, -31 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 6 chunks +31 lines, -65 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.h View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/compositor_impl_android.h View 4 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M trunk/src/content/public/browser/android/compositor.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/content/public/browser/android/compositor_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/ui/gfx/android/java_bitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ui/gfx/android/java_bitmap.cc View 2 chunks +27 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
7 years, 3 months ago (2013-09-13 23:57:48 UTC) #1
Zhenyao Mo
7 years, 3 months ago (2013-09-13 23:58:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223180.

Powered by Google App Engine
This is Rietveld 408576698