Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: LayoutTests/inspector/console/console-uncaught-exception-in-eval.html

Issue 23717011: DevTools: Use scriptId for resolving stack frames in console messages (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/console/console-uncaught-exception-in-eval.html
diff --git a/LayoutTests/inspector/console/console-uncaught-exception-in-eval.html b/LayoutTests/inspector/console/console-uncaught-exception-in-eval.html
index a3a7e450df8fb2ed02b22a2ac4380b56a8072f0c..e085899d102c5801ac16a994ace0743fb556b1ee 100644
--- a/LayoutTests/inspector/console/console-uncaught-exception-in-eval.html
+++ b/LayoutTests/inspector/console/console-uncaught-exception-in-eval.html
@@ -4,20 +4,11 @@
<script src="../../http/tests/inspector/console-test.js"></script>
<script>
-function test()
-{
- InspectorTest.reloadPage(function() {
- InspectorTest.expandConsoleMessages();
- InspectorTest.dumpConsoleMessages();
- InspectorTest.completeTest();
- });
-}
-
-function evalSource()
+function evalSource(name)
{
function b()
{
- throw new Error("Exception in eval.");
+ throw new Error("Exception in eval:" + name);
}
function a()
@@ -28,7 +19,42 @@ function evalSource()
a();
}
-eval("(" + evalSource + ")()//# sourceURL=evalURL.js");
+function doEvalWithSourceURL()
+{
+ var source = "(" + evalSource + ")(\"with sourceURL\")//# sourceURL=evalURL.js";
+ setTimeout(eval.bind(this, source), 0);
+}
+
+function doAnonymousEvalWith()
+{
+ var source = "(" + evalSource + ")(\"anonymous\")";
+ setTimeout(eval.bind(this, source), 0);
+}
+
+function test()
+{
+ InspectorTest.evaluateInPage("doEvalWithSourceURL()", step2.bind(this));
+
+ function step2()
+ {
+ InspectorTest.evaluateInPage("doAnonymousEvalWith()", step3.bind(this));
+ }
+
+ function step3()
+ {
+ if (WebInspector.consoleView._visibleMessagesIndices < 2)
+ InspectorTest.addConsoleSniffer(step3);
+ else
+ step4();
+ }
+
+ function step4()
+ {
+ InspectorTest.expandConsoleMessages();
+ InspectorTest.dumpConsoleMessages();
+ InspectorTest.completeTest();
+ }
+}
</script>
</head>

Powered by Google App Engine
This is Rietveld 408576698