DevTools: Use scriptId for resolving stack frames in console messages

Source/devtools/front_end/ConsoleMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 145 matching lines @@
                     this._anchorElement = WebInspector.linkifyURLAsNode(this.url, this.url, "console-message-url", isExternal);
                 }
                 this._messageElement = this._format([this._messageText]);
             }
         } else {
             var args = this._parameters || [this._messageText];
             this._messageElement = this._format(args);
         }
 
         if (this.source !== WebInspector.ConsoleMessage.MessageSource.Network || this._request) {
-            if (this._stackTrace && this._stackTrace.length && this._stackTrace[0].url) {
+            if (this._stackTrace && this._stackTrace.length && this._stackTrace[0].scriptId) {
                 this._anchorElement = this._linkifyCallFrame(this._stackTrace[0]);
             } else if (this.url && this.url !== "undefined") {
                 this._anchorElement = this._linkifyLocation(this.url, this.line, this.column);
             }
         }
 
         this._formattedMessage.appendChild(this._messageElement);
         if (this._anchorElement) {
             this._formattedMessage.appendChild(document.createTextNode(" "));
             this._formattedMessage.appendChild(this._anchorElement);
@@ skipping 61 matching lines @@
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         return this._linkifier.linkifyLocation(url, lineNumber, columnNumber, "console-message-url");
     },
 
     /**
      * @param {!ConsoleAgent.CallFrame} callFrame
      * @return {Element}
      */
     _linkifyCallFrame: function(callFrame)
     {
-        return this._linkifyLocation(callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
+        // FIXME(62725): stack trace line/column numbers are one-based.
+        var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
+        var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
+        var rawLocation = new WebInspector.DebuggerModel.Location(callFrame.scriptId, lineNumber, columnNumber);
+        return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
     },
 
     /**
      * @return {boolean}
      */
     isErrorOrWarning: function()
     {
         return (this.level === WebInspector.ConsoleMessage.MessageLevel.Warning || this.level === WebInspector.ConsoleMessage.MessageLevel.Error);
     },
 
@@ skipping 528 matching lines @@
         for (var i = 0; i < this._stackTrace.length; i++) {
             var frame = this._stackTrace[i];
 
             var content = document.createElement("div");
             var messageTextElement = document.createElement("span");
             messageTextElement.className = "console-message-text source-code";
             var functionName = frame.functionName || WebInspector.UIString("(anonymous function)");
             messageTextElement.appendChild(document.createTextNode(functionName));
             content.appendChild(messageTextElement);
 
-            if (frame.url) {
+            if (frame.scriptId) {
                 content.appendChild(document.createTextNode(" "));
                 var urlElement = this._linkifyCallFrame(frame);
                 content.appendChild(urlElement);
             }
 
             var treeElement = new TreeElement(content);
             parentTreeElement.appendChild(treeElement);
         }
     },
 
@@ skipping 150 matching lines @@
     /**
      * @return {WebInspector.ConsoleMessage}
      */
     clone: function()
     {
         return WebInspector.ConsoleMessage.create(this.source, this.level, this._messageText, this.type, this.url, this.line, this.column, this.repeatCount, this._parameters, this._stackTrace, this._request ? this._request.requestId : undefined, this._isOutdated);
     },
 
     __proto__: WebInspector.ConsoleMessage.prototype
 }