Remove non-elderberry herb flavors.

Remove non-elderberry herb flavors.

BUG=650769
Committed: https://crrev.com/b07bdff26defb2c8f81ed9050e295acac91364fe
Cr-Commit-Position: refs/heads/master@{#421865}

[Ted C, 2016-09-27 19:58:26]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2016-09-27 19:58:27]

PTAL

[gone, 2016-09-28 16:45:46]

lgtm

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:338:
assert false;
You should remove this assert in case anyone got stuck on the old flavor
somehow.  Granted, we haven't been able to assert in ages.

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
(right):

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java:208:
|| newFlavor.startsWith(ChromeSwitches.HERB_FLAVOR_DEFAULT)) {
Should this just be the "else" clause to catch all people who flipped on other
flavors?

https://chromiumcodereview.appspot.com/2371003003/diff/1/tools/metrics/histog...
File tools/metrics/histograms/histograms.xml (left):

https://chromiumcodereview.appspot.com/2371003003/diff/1/tools/metrics/histog...
tools/metrics/histograms/histograms.xml:86967: -  <int value="-1467332609"
label="tab-management-experiment-type-anise"/>
I think this place is supposed to be a graveyard of every flag ever added so
that the dashboard keeps making sense.

[Ted C, 2016-09-28 23:21:37]

tedchoc@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Ted C, 2016-09-28 23:21:38]

+rkaplow for actions.xml OWNERS

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:338:
assert false;
On 2016/09/28 16:45:46, dfalcantara (slow) wrote:
> You should remove this assert in case anyone got stuck on the old flavor
> somehow.  Granted, we haven't been able to assert in ages.

True...I thought getHerbFlavor did the sanitizing, but it is actually
cacheHerbFlavor.  Will do.

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
(right):

https://chromiumcodereview.appspot.com/2371003003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java:208:
|| newFlavor.startsWith(ChromeSwitches.HERB_FLAVOR_DEFAULT)) {
On 2016/09/28 16:45:46, dfalcantara (slow) wrote:
> Should this just be the "else" clause to catch all people who flipped on other
> flavors?

Done, although I don't "think" this is necessary (does clean it up a bit
though).

I think findFullName would have returned null/empty or one of these two if the
user was in a non-supported flavor.  So, I believe the newFlavor was being
set to DISABLED anyway.

https://chromiumcodereview.appspot.com/2371003003/diff/1/tools/metrics/histog...
File tools/metrics/histograms/histograms.xml (left):

https://chromiumcodereview.appspot.com/2371003003/diff/1/tools/metrics/histog...
tools/metrics/histograms/histograms.xml:86967: -  <int value="-1467332609"
label="tab-management-experiment-type-anise"/>
On 2016/09/28 16:45:46, dfalcantara (slow) wrote:
> I think this place is supposed to be a graveyard of every flag ever added so
> that the dashboard keeps making sense.

Undone

[rkaplow, 2016-09-29 16:52:27]

lgtm

[Ted C, 2016-09-29 17:00:12]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-09-29 17:00:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2371003003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-29 17:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 17:43:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 17:46:53]

Description was changed from

==========
Remove non-elderberry herb flavors.

BUG=650769
==========

to

==========
Remove non-elderberry herb flavors.

BUG=650769

Committed: https://crrev.com/b07bdff26defb2c8f81ed9050e295acac91364fe
Cr-Commit-Position: refs/heads/master@{#421865}
==========

[commit-bot: I haz the power, 2016-09-29 17:46:54]

Patchset 3 (id:??) landed as
https://crrev.com/b07bdff26defb2c8f81ed9050e295acac91364fe
Cr-Commit-Position: refs/heads/master@{#421865}