chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java - Issue 2371003003: Remove non-elderberry herb flavors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java

Issue 2371003003: Remove non-elderberry herb flavors. (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java

index cb6cdff3437b98586eb8eae481ffcd33bf16b58f..2c1b266be256cd881166fdf08e24bf5569eb9169 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityStopMetrics.java

@@ -21,9 +21,6 @@ public class ActivityStopMetrics {

@IntDef({

STOP_REASON_UNKNOWN,

STOP_REASON_BACK_BUTTON,

- STOP_REASON_RETURN_BUTTON,

- STOP_REASON_CUSTOM_TAB_STARTED,

- STOP_REASON_CUSTOM_TAB_STOPPED,

STOP_REASON_OTHER_CHROME_ACTIVITY_IN_FOREGROUND,

STOP_REASON_COUNT

})

@@ -35,14 +32,15 @@ public class ActivityStopMetrics {

/** Activity stopped after the user hit the back button. */

public static final int STOP_REASON_BACK_BUTTON = 1;

- /** Activity stopped after the user hit the close/return UI button. */

- public static final int STOP_REASON_RETURN_BUTTON = 2;

+ // Obsolete -- Activity stopped after the user hit the close/return UI button.

+ // public static final int STOP_REASON_RETURN_BUTTON = 2;

- /** Activity stopped because it launched a {@link CustomTabActivity} on top of itself. */

- public static final int STOP_REASON_CUSTOM_TAB_STARTED = 3;

+ // Obsolete -- Activity stopped because it launched a {@link CustomTabActivity} on top of

+ // itself.

+ // public static final int STOP_REASON_CUSTOM_TAB_STARTED = 3;

- /** Activity stopped because its child {@link CustomTabActivity} stopped itself. */

- public static final int STOP_REASON_CUSTOM_TAB_STOPPED = 4;

+ // Obsolete -- Activity stopped because its child {@link CustomTabActivity} stopped itself.

+ // public static final int STOP_REASON_CUSTOM_TAB_STOPPED = 4;

/** Activity stopped because another of Chrome Activities came into focus. */

public static final int STOP_REASON_OTHER_CHROME_ACTIVITY_IN_FOREGROUND = 5;