Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4567)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 23708004: Translate: Remove --enable-translate-settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify TranslateManagerBrowserTest.NeverTranslateLanguagePref Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 9188acf78245cf0de6cc70e72d65a0942bf76460..41432a5ff7ca6e41248724353c38751dd8015793 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -352,8 +352,6 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
std::string target_lang = GetTargetLanguage(prefs);
std::string language_code = GetLanguageCode(page_lang);
- CommandLine* command_line = CommandLine::ForCurrentProcess();
-
// Don't translate similar languages (ex: en-US to en).
if (language_code == target_lang) {
TranslateBrowserMetrics::ReportInitiationStatus(
@@ -361,17 +359,6 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
return;
}
- // Don't translate any language the user configured as accepted languages.
- // When the flag --enable-translate-settings is on, the condition is
- // different. In this case, even though a language is an Accept language,
- // it could be translated due to the blacklist.
- if (!command_line->HasSwitch(switches::kEnableTranslateSettings) &&
- accept_languages_->IsAcceptLanguage(original_profile, language_code)) {
- TranslateBrowserMetrics::ReportInitiationStatus(
- TranslateBrowserMetrics::INITIATION_STATUS_ACCEPT_LANGUAGES);
- return;
- }
-
// Nothing to do if either the language Chrome is in or the language of the
// page is not supported by the translation server.
if (target_lang.empty() || !IsSupportedLanguage(language_code)) {
« no previous file with comments | « chrome/browser/translate/translate_accept_languages.cc ('k') | chrome/browser/translate/translate_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698